[wip] Port some keystore functions to Rust #1425
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until the relevant keystore.c functions are ported too, we keep the cipher.c/cipher.h interface but have it call into Rust. The test_cipher.c tests were ported and the test generator script adatped to produce Rust output.
It causes a long delay before the orientation animation. It's a sanity check only, so doing it as part of the factory setup only suffices. We also enable it in debug builds, so it catches a misconfigured device (e.g. if you forgot to run factorysetup on a new PCB).
No caller ran into this, but good to make sure.
So C tests can be shown to pass with the Rust impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.