ble-bootloader: Add device name to default screen #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickeZ
force-pushed
the
nickez/device-name-bootloader
branch
from
c1bd399 to
89c0106
Compare
benma
reviewed
May 14, 2025
src/bootloader/bootloader.c
Outdated
| #if PLATFORM_BITBOX02PLUS == 1 | ||
| char buf[MEMORY_DEVICE_NAME_MAX_LEN] = {0}; | ||
| memory_random_name(buf); | ||
| UG_PutString(0, SCREEN_HEIGHT - 9, buf, false); |
There was a problem hiding this comment.
Probably should do it only if ble is enabled and not already connected? If you reboot to upgrade and you are still connected, there is no need to see some random letters 😄
NickeZ
force-pushed
the
nickez/device-name-bootloader
branch
6 times, most recently
from
668a5d7 to
8c15b9e
Compare
Only show device name before user has paired and if no USB communication has occurred. Add a new BLE firmware that supports requesting the current connection state. This is neeeded because after a reboot from firmware to bootloader the bootloader isn't aware of the connection state.
NickeZ
force-pushed
the
nickez/device-name-bootloader
branch
from
8c15b9e to
7d4d357
Compare
NickeZ
force-pushed
the
nickez/device-name-bootloader
branch
from
7d4d357 to
9e3faf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user needs the device name to pair