Fix/bottom tap while gesture confirm #1616
Conversation
NickeZ
force-pushed
the
fix/bottom-tap-while-gesture-confirm
branch
3 times, most recently
from
2fa485b to
f271546
Compare
| // Render confirm button or gesture (render confirm gesture last so that bottom triangle is | ||
| // above keyboard) |
There was a problem hiding this comment.
so that bottom triangle is above keyboard
The keyboard is not rendered while the confirm gesture is active. Is this comment about something else?
There was a problem hiding this comment.
Not true, you can clearly see the bottom triangle "animating out" beneath the keyboard.
There was a problem hiding this comment.
So the keyboard (and everything else) is not rendered while the bottom triangle is animating in, but it is rendered when it is animated out. Not a big deal, but I wonder if that should be changed so it waits until the bottom triangle is gone before rendering the rest again.
Quick patch to achieve this (not sure if this is a good way, but it works):
Feels pretty good in my opinion, please try it.
There was a problem hiding this comment.
also tried it, I really like it. Switched to that implementation.
Extend the duration for when the confirm gesture is active so that involuntary bottom taps are not triggered and so that the confirm gesture triangle isn't rendered blended into the keyboard.
NickeZ
force-pushed
the
fix/bottom-tap-while-gesture-confirm
branch
from
f271546 to
b586290
Compare
2 participants
No description provided.