maintenance: allow reuse of address and port for the simulator. #1626
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the simulator can be killed and immediately restarted without encountering the "address already in use" error.
|
Moving it back to draft as I'm not sure it fixes the issue :( |
|
Reopened: I verified and it does indeed solve the issue in my tests. Using the simulator without this patch makes it fail when starting again after killing it, while with this version it works |
|
Please try this solution instead. I'm not sure what SO_REUSEADDR implicates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the simulator can be killed and immediately restarted without encountering the "address already in use" error.
I'm not sure if there is a better way to achieve this, I got some AI help to arrive to this :) But it does make my automatic testing more reliable, while without this option it would fail when restarting the simulator with the error mentioned above.