chore(statics): add babylon to statics #5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedRyaan786
force-pushed
the
COIN-2691-sdk-statics-for-babylon
branch
5 times, most recently
from
9e413c9 to
9c8ddc0
Compare
at31416
reviewed
Jan 9, 2025
MohammedRyaan786
force-pushed
the
COIN-2691-sdk-statics-for-babylon
branch
2 times, most recently
from
0d6e75c to
8aa2d8e
Compare
MohammedRyaan786
requested review from
alebusse,
varun-bitgo,
at31416 and
mohitkh7
mohitkh7
reviewed
Jan 10, 2025
modules/statics/src/coins.ts
Outdated
| account( | ||
| 'ee22282b-c307-4861-b706-d9a178326ad5', | ||
| 'tbaby', | ||
| 'Testnet Baby', |
There was a problem hiding this comment.
It should be named as Testnet Babylon
mohitkh7
reviewed
Jan 10, 2025
| 'baby', | ||
| 'Babylon', | ||
| Networks.main.baby, | ||
| 6, |
There was a problem hiding this comment.
Please share the babylon docs reference in PR description which highlights 6 decimal places.
There was a problem hiding this comment.
I've updated the description with the right reference
mohitkh7
reviewed
Jan 10, 2025
mohitkh7
reviewed
Jan 10, 2025
modules/statics/src/networks.ts
Outdated
| class Baby extends Mainnet implements AccountNetwork { | ||
| name = 'Babylon'; | ||
| family = CoinFamily.BABY; | ||
| explorerUrl = ''; |
There was a problem hiding this comment.
We can put explorerUrl as https://babylon.explorers.guru/
Explorers.guru followed similar pattern for other chains, so we can safely assume mainnet explorer URL will be same.
mohitkh7
reviewed
Jan 10, 2025
modules/statics/src/networks.ts
Outdated
| class BabyTestnet extends Testnet implements AccountNetwork { | ||
| name = 'Testnet Babylon'; | ||
| family = CoinFamily.BABY; | ||
| explorerUrl = 'https://testnet.babylon.explorers.guru/'; |
There was a problem hiding this comment.
Suggested change
| explorerUrl = 'https://testnet.babylon.explorers.guru/'; | |
| explorerUrl = 'https://testnet.babylon.explorers.guru/transaction/'; |
It should be transactions URL. Applies to mainnet class as well
MohammedRyaan786
force-pushed
the
COIN-2691-sdk-statics-for-babylon
branch
from
8aa2d8e to
49d5583
Compare
at31416
approved these changes
Jan 10, 2025
alebusse
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: COIN-2691
Added babylon to statics. Currently since mainnet is not yet live, have left the explorer url empty. Have created a ticket to add the mainnet explorer link later on : https://bitgoinc.atlassian.net/browse/COIN-2758
Phase-2 Testnet Network Information
Following is a list of the key network details of the Babylon Phase-2 Testnet (testnet-5):
RPC nodes can be found here
Chain ID: bbn-test-5
Bech32 Configuration can be found here
Token minimum denomination: ubbn (6 decimals)
Human-readable denomination: tbaby (test baby)
Reference - Babylon Github: https://github.com/babylonlabs-io/networks/blob/030a0c7b29b1156840383e09816b4187560c41e4/bbn-test-5/integration/wallet/babylon-wallet.md