feat(sdk-coin-baby): add SDK support for babylon #5382
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedRyaan786
force-pushed
the
COIN-2761-sdk-add-sdk-support
branch
7 times, most recently
from
db6ec7e to
fa1fed4
Compare
modules/sdk-coin-baby/test/unit/transactionBuilder/transferBuilder.ts
Outdated
Show resolved
Hide resolved
mohitkh7
reviewed
Jan 17, 2025
Comment on lines
+2
to
+4
| export const accountAddressRegex = /^(bbn)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/; | ||
| export const validatorAddressRegex = /^(bbnvaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/; | ||
| export const contractAddressRegex = /^(bbn)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]+)$/; |
There was a problem hiding this comment.
This regex doesn't seems to be correct. Ideally it should accept all alphanumeric characters in the address body of length 38.
MohammedRyaan786
force-pushed
the
COIN-2761-sdk-add-sdk-support
branch
from
fa1fed4 to
932541b
Compare
margueriteblair
previously approved these changes
Jan 20, 2025
MohammedRyaan786
force-pushed
the
COIN-2761-sdk-add-sdk-support
branch
from
2a36edd to
3683915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: COIN-2761