Skip to content

chore: gate keep tokens for SINGAPORE and MENA trust #6255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

chore: gate keep tokens for SINGAPORE and MENA trust #6255

merged 1 commit into from
Jun 10, 2025
+108 −14

Conversation

prithvishet2503
Copy link
Contributor

Ticket: WIN-5769

@prithvishet2503 prithvishet2503 force-pushed the WIN-5769 branch 5 times, most recently from 29fce7e to 2011836 Compare June 9, 2025 12:38
@prithvishet2503 prithvishet2503 marked this pull request as ready for review June 9, 2025 15:17
@prithvishet2503 prithvishet2503 requested review from a team as code owners June 9, 2025 15:17
pranavjain97
pranavjain97 previously requested changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@pranavjain97 pranavjain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CODEOWNERS. These are all coin specific files and shoudn't need a WP review

@prithvishet2503 prithvishet2503 removed the request for review from lokesh-bitgo June 10, 2025 05:32
@prithvishet2503 prithvishet2503 requested a review from a team as a code owner June 10, 2025 05:39
@prithvishet2503
Copy link
Contributor Author

Please update the CODEOWNERS. These are all coin specific files and shoudn't need a WP review

addressed

MohammedRyaan786
MohammedRyaan786 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@MohammedRyaan786 MohammedRyaan786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nvrakesh06
nvrakesh06 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@nvrakesh06 nvrakesh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivabitgo shivabitgo dismissed pranavjain97’s stale review June 10, 2025 06:54

Dismissing this review to be able to merge. Have addressed the request changes

@shivabitgo shivabitgo merged commit 97ffb53 into master Jun 10, 2025
12 checks passed
Phani024
Phani024 reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@Phani024 Phani024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phani024 Phani024 Phani024 left review comments

@sijuu sijuu sijuu approved these changes

@nvrakesh06 nvrakesh06 nvrakesh06 approved these changes

@MohammedRyaan786 MohammedRyaan786 MohammedRyaan786 approved these changes

@pranavjain97 pranavjain97 Awaiting requested review from pranavjain97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@prithvishet2503 @pranavjain97 @Phani024 @sijuu @nvrakesh06 @MohammedRyaan786 @shivabitgo