Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wrw): config changes addition of avaxc coin #505

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore(wrw): config changes addition of avaxc coin #505

merged 1 commit into from
Oct 7, 2024

Conversation

nrjsuthar
Copy link
Contributor

kamleshmugdiya
kamleshmugdiya requested changes Sep 18, 2024
View reviewed changes
src/helpers/config.ts Outdated Show resolved Hide resolved
src/helpers/config.ts Outdated Show resolved Hide resolved
src/helpers/config.ts Outdated Show resolved Hide resolved
kamleshmugdiya
kamleshmugdiya previously approved these changes Sep 18, 2024
View reviewed changes
@venkateshv1266
Copy link
Contributor

Can u please squash all 4 commits?

@nrjsuthar
Copy link
Contributor Author

Working on the same @venkateshv1266

kamleshmugdiya
kamleshmugdiya requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@kamleshmugdiya kamleshmugdiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 please squash your commits.

@nrjsuthar
Copy link
Contributor Author

@kamleshmugdiya @venkateshv1266 Done

kamleshmugdiya
kamleshmugdiya previously approved these changes Sep 18, 2024
View reviewed changes
@nrjsuthar nrjsuthar marked this pull request as draft September 23, 2024 17:07
@nrjsuthar nrjsuthar force-pushed the feature/COIN-1708 branch 2 times, most recently from a743fcb to 5058eea Compare September 26, 2024 08:52
@nrjsuthar nrjsuthar marked this pull request as ready for review September 26, 2024 08:56
@venkateshv1266
Copy link
Contributor

Please squash the commits

@nrjsuthar nrjsuthar force-pushed the feature/COIN-1708 branch 3 times, most recently from 0612a8b to 74be04f Compare October 7, 2024 06:25
@venkateshv1266
Copy link
Contributor

Remove yarn.lock file. Since we use npm to install dependencies in wrw, yarn.lock file is not required.

@nrjsuthar nrjsuthar merged commit 0e6ae2b into master Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkateshv1266 venkateshv1266 venkateshv1266 approved these changes

@mullapudipruthvik mullapudipruthvik Awaiting requested review from mullapudipruthvik

@kamleshmugdiya kamleshmugdiya Awaiting requested review from kamleshmugdiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrjsuthar @venkateshv1266 @kamleshmugdiya