feat(ci): screen-zoo — OLED screenshots as CI artifact#68
Open
BitHighlander wants to merge 16 commits intodevelopfrom
Open
feat(ci): screen-zoo — OLED screenshots as CI artifact#68BitHighlander wants to merge 16 commits intodevelopfrom
BitHighlander wants to merge 16 commits intodevelopfrom
Conversation
Captures device OLED framebuffer PNGs for every PR against develop: - Zcash: Orchard FVK export, PCZT signing, transparent signing - Solana: address derivation - Ethereum: address, sign tx, transfers, ERC-20 approvals, messages How it works: - client.py now supports KEEPKEY_SCREENSHOT=1 env var (was hardcoded off) - screen-zoo.sh runs targeted test suites with PIL capture enabled - New CI job uploads screen-zoo/ artifact with per-chain directories - 90-day retention, runs in parallel with existing test jobs Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The previous commit changed deps/python-keepkey submodule pointer to a local-only commit, breaking CI. Fix: revert submodule to upstream, and have screen-zoo.sh sed-patch client.py at runtime to enable screenshots.
The previous commit pointed deps/python-keepkey to a local-only commit that CI cannot fetch. Reverted to 0f6be2b4 (upstream). Screenshot support is now patched at runtime by screen-zoo.sh via sed.
Previous run failed because: - emu image doesn't have pytest or Pillow installed - zoo script ran in a container that couldn't reach the emulator Fix: - zoo script now pip-installs pytest + Pillow + python-keepkey - emulator and zoo run in the same container (bridge + kkemu + script) - only mount screen-zoo output dir and zoo script (don't override /kkemu)
- Dockerfile: install Pillow, pytest, python-keepkey at build time - Merge build-emulator + unit-tests + screen-zoo into one job - emu-image artifact only uploaded on workflow_dispatch (publish) - Normal PRs upload only: unit-test-results + screen-zoo PNGs
Tests import keepkeylib via sys.path manipulation, not pip. The zoo script just needs to sed-replace SCREENSHOT = False with the PIL import + True. Removed all pip install attempts, verification scripts, and multi-line python patching that was causing failures.
- Base image is Alpine, not Debian — apt-get doesn't exist - Use apk add py3-pillow, fallback to building from source with dev headers - pytest was already installed in base image - Upload step now errors on empty zoo instead of silently passing
…utput for debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screen-zooartifact with pixel-by-pixel OLED screenshots from the emulatorKEEPKEY_SCREENSHOT=1env var enables capture in python-keepkey (was hardcoded off)What's in the artifact
Test plan