Repository navigation
Conversation
2 tasks done
Collaborator
|
Closing for now. We'll reopen if work on #501 is resumed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realtime Runtime: Session Lifecycle + Streaming + Chunk/Overlap Decoding
This PR adds the dedicated MOSS realtime runtime path, including explicit session lifecycle controls, incremental text-delta streaming, and chunked audio decoding with overlap crossfade.
Scope (Included)
This PR includes:
mlx_audio/tts/models/moss_tts_realtime/**mlx_audio/tts/tests/test_moss_tts_realtime_runtime.pytests/tts/models/moss_tts_realtime/test_realtime_regressions.pyexamples/moss_tts_realtime_multiturn_agent.pyexamples/moss_tts_realtime_text_deltas.pymlx_audio/tts/models/qwen3_tts/speech_tokenizer.pyPrimary behavior in scope:
reset_turn-> text ingestion ->end_text->drain.chunk_frames,overlap_frames).Scope (Intentionally Excluded)
This PR does not include:
mlx_audio/tts/models/moss_tts/**).mlx_audio/tts/generate.py.mlx_audio/server.py.Validation
Additional targeted checks run during review:
Result:
3 passed(targeted overlap/bridge checks).Manual Smoke Notes
RealtimeSessionAPI semantics and lifecycle method signatures.[0.4583, 0.2083][0.9583, 0.9583]Reviewer Guide
Suggested review order:
test_moss_tts_realtime_runtime.py, realtime regressions).inference.pysession lifecycle and decoder/backpressure/crossfade paths.model.pyrealtime runtime wiring and generation flow.moss_tts_realtime_text_deltas.py,moss_tts_realtime_multiturn_agent.py) for user-facing contract parity.