Repository navigation
Moss tts server - #506
Closed
voxmenthe wants to merge 10 commits into
Closed
Moss tts server#506voxmenthe wants to merge 10 commits into
voxmenthe wants to merge 10 commits into
Conversation
2 tasks done
The STS LFM output contract test intermittently fails on macOS CI with: [metal::Device] Unable to load kernel rbitsc (Compilation failed). Changes: - Add an exact matcher for the known MLX Metal `rbitsc` compile failure. - Wrap `mx.eval(...)` calls in a helper that retries once after `mx.clear_cache()`. - If retry still fails, skip only when `CI` is set. - Re-raise locally and re-raise all non-matching RuntimeErrors (no masking of real regressions).
Collaborator
|
Closing for now. We'll reopen if work on #501 is resumed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server API Surface: Request Fields, Reserved
model_kwargsSafety, Optional FallbacksThis PR focuses on server-facing request handling and validation behavior for audio endpoints, with emphasis on safe passthrough semantics and clear failure modes.
Scope (Included)
This PR includes:
mlx_audio/server.pymlx_audio/tests/test_server.pymlx_audio/sts/voice_pipeline.pymlx_audio/sts/tests/test_voice_pipeline.pymlx_audio/stt/models/qwen3_forced_aligner/__init__.pyPrimary behavior in scope:
/v1/audio/speechrequest-surface expansion for advanced generation controls.model_kwargscollisions to prevent ambiguous/duplicate generation arguments.Scope (Intentionally Excluded)
This PR does not include:
mlx_audio/tts/models/moss_tts_realtime/**.mlx_audio/tts/models/moss_tts/**.mlx_audio/tts/generate.py.Validation
Targeted safety check executed:
Result:
1 passed.Manual Verification Notes
model_kwargscollisions return HTTP 400 and include clear guidance:_validate_reserved_model_kwargs(...)inmlx_audio/server.py.model_kwargs contains reserved generation arguments (...)Pass these as top-level request fields instead.mlx_audio/server.pymlx_audio/tests/test_server.pymlx_audio/sts/voice_pipeline.pymlx_audio/sts/tests/test_voice_pipeline.pymlx_audio/stt/models/qwen3_forced_aligner/__init__.pyReviewer Guide
Suggested review order:
mlx_audio/tests/test_server.py(especially reservedmodel_kwargsrejection case).mlx_audio/server.pyrequest parsing + validation flow.mlx_audio/sts/voice_pipeline.pyandmlx_audio/sts/tests/test_voice_pipeline.py.mlx_audio/stt/models/qwen3_forced_aligner/__init__.py(scope-limited integration touchpoint).