Open
Conversation
added 10 commits
March 20, 2026 02:02
This reverts commit cec542a.
lucasnewman
requested changes
Apr 10, 2026
Collaborator
lucasnewman
left a comment
There was a problem hiding this comment.
@Talpik Thanks for the contribution!
Can we split this into two PRs to reduce the size of the changes needed to review?
- The model updates, which should be verifiable against the reference implementation.
- The selective quantization enhancements that you've added for the performance tuning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR improves non-streaming
VibeVoice-7Bsupport inmlx-audioand makes it substantially morepractical on Apple Silicon.
The work had two goals:
vibevoice-community/ VibeVoiceimplementationspeed/quality tradeoffs
The implementation was tuned and validated against the original upstream repo on a
MacBook Pro 16" (M4 Max, 48GB RAM).Description
The non-streaming
VibeVoice-7Bpath was adapted and corrected to better match upstream behavior,including prompt handling, reference voice prefill, negative-branch logic, grouped-query attention
behavior, and acoustic encoder parity.
After parity was improved, the runtime was profiled and selective quantization support was added in a
model-aware way, instead of relying only on the generic “quantize everything quantizable” path.
The PR also makes selectively-quantized checkpoints self-describing by saving quantized component
metadata into
config.json, and updates model loading so quantized packed weights can be reconstructedcorrectly during reload.
Experimental preset layers, speculative CFG speed paths, and investigation-only CLI tuning flags were
intentionally left out of this PR to keep the public surface area small and stable.
Changes in the codebase
VibeVoice-7Binference parity with upstreamVibeVoice-specific selective quantization policyquantized_componentsmetadata during conversionmlx_audio.tts.generateCLI by removing VibeVoice-specific experimental tuningflags
VibeVoicetest coverage for parity-sensitive and quantized-loading behaviorChanges outside the codebase
No infrastructure, database, or external service changes were made.
The original
vibevoice-community/VibeVoicerepository was used as the behavioral reference for paritychecks and runtime comparisons.
Additional information
Main comparison setup:
cfg_scale=1.5ddpm_steps=10Main comparison matrix
25.07s42.65s0.59x26.00s103.02s0.25x25.21GB25.60s21.12s1.21x9.57GB25.73s24.02s1.07x14.19GBModel preparation
Before running the commands below, download the original upstream
vibevoice-community/VibeVoiceweights locally.Assume the original PyTorch checkpoint is available at:
<ORIGINAL_VIBEVOICE_WEIGHTS>1. Full MLX port