Remove all remaining torch calls#95
Merged
Merged
Conversation
Owner
|
Perfect, indeed it was the only missing dependencies! However, users will still need torch so transformers can return torch tensors inputs for LLM based TTS models. So we before we remove it we need to replace Ideally with a fallback to torch, such as this: |
Owner
|
Seems like all models are fine and return “mlx” specified, expect Sesame: |
…t dependency from transformers.
Collaborator
Author
|
Thanks. I also pulled in the load_config() call from mlx-vlm since it's pretty small and avoids some implicit dependencies on mlx-vlm -> transformers -> torch.hub. |
Blaizzy
reviewed
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only remaining caller of torch was the Kokoro voice loader, and we can replicate that with a small pickle-based loader to load the single tensor .pt files.