Updating Version of Jmeter to 5.6.2 #1776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1776 +/- ##
==========================================
+ Coverage 89.06% 89.11% +0.05%
==========================================
Files 70 70
Lines 18996 18978 -18
==========================================
- Hits 16917 16910 -7
+ Misses 2079 2068 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kamyarz-aws
commented
Oct 15, 2023
| return direct_install_tools | ||
|
|
||
| def _fix_jquery_in_jmeter(self, jmeter_dir): | ||
| if not self.fix_jars or LooseVersion(self.version) < LooseVersion('5.0.0'): |
Author
There was a problem hiding this comment.
Deleted this function since LooseVersion is never less than 5 so it could be deleted
kamyarz-aws
changed the title
Author
|
@mykhaliev1 I am unable to add reviewers to this. I made these changes. All the pipelines are passing. I did the docker build and ran a couple tests on top of it and it works. |
kamyarz-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each PR must conform to Developer's Guide.
Updating JMETER Version to 5.6.2.
Quick checklist:
site/dat/docs/changesdirectory, one-line note of change inside