-
Notifications
You must be signed in to change notification settings - Fork 466
Allow k6 scenario to be defined within k6 test #1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asos-benpearson
wants to merge
30
commits into
Blazemeter:master
Choose a base branch
from
benpearson84:fix/k6-scenario-within-k6-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7a3e253
Add K6 own get_load method
asos-benpearson 9d8904b
add vscode to gitignore
asos-benpearson 0ca4a2c
added change file
asos-benpearson bc33321
Merge branch 'master' of https://github.com/benpearson84/taurus into …
asos-benpearson 8334e75
add tests
asos-benpearson 32085e8
fix broken test
asos-benpearson 5c6a3ee
Merge branch 'master' of https://github.com/benpearson84/taurus into …
asos-benpearson 35a8536
fix tests to cover new get_load method
asos-benpearson 11f6c4b
missing self parameter
asos-benpearson 28bcb56
fix broken test
asos-benpearson dd259dd
fix test_get_load_str_fail test
asos-benpearson 1c2d174
improve code coverage
asos-benpearson 9334acd
Update docymentation to include example yaml
asos-benpearson 3f27103
Merge branch 'Blazemeter:master' into fix/k6-scenario-within-k6-test
asos-benpearson 06c7c47
Update __init__.py
asos-benpearson cd1b215
Merge branch 'master' of https://github.com/benpearson84/taurus into …
asos-benpearson 3889e0f
Merge branch 'fix/k6-scenario-within-k6-test' of https://github.com/b…
asos-benpearson 53b15f1
Merge pull request #1 from Blazemeter/master
asos-benpearson 4c13ba1
Merge branch 'master' of https://github.com/benpearson84/taurus into …
asos-benpearson 0a04df6
Merge pull request #2 from benpearson84/fix/k6-scenario-within-k6-test
asos-benpearson d62ecf8
Remove --out to csv file as not required
asos-benpearson ef851b4
fix broken kpi test
asos-benpearson 98f9963
Allow KPI csv to be disabled via modifications block within scenario
asos-benpearson a1aad4a
Merge branch 'master' of https://github.com/benpearson84/taurus into …
asos-benpearson 60ee59d
git ignore
asos-benpearson aa7019c
Merge branch 'master' into fix/k6-scenario-within-k6-test
benpearson84 e0344c5
add vscode gitignore
asos-benpearson 72f34ef
use latest jmeter version
asos-benpearson 3f414b1
Merge branch 'Blazemeter:master' into fix/k6-scenario-within-k6-test
benpearson84 890c7e7
Merge branch 'Blazemeter:master' into fix/k6-scenario-within-k6-test
asos-benpearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks Taurus' handling of K6 results when more than one scenario is executed in parallel.
In the previous version, Taurus managed the creation of files like kpi-1.csv, kpi-2.csv, etc. automatically.
With this change, we now have to manually configure this setup.
Error:
Child Process Error: Empty results, most likely xxx (K6Executor) failed. Actual reason for this can be found in logs under...
(but the execution was a success. However, due to this error status, the execution is considered a failure in the pipeline)
For a complex execution involving multiple scenarios running in parallel, this increases the complexity of the user's code for something that was previously managed internally.
Therefore, I’d like to understand the reasoning behind removing this default functionality, if possible. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah Im aware of this. However, this PR has been raised for over a year with no communication from the project maintainers at all so we have been using this Fork instead. We decided we dont need the results output to file as we output to an InfluxDB instead and we dont care about the overall Taurus result so this 'quick' fix works for us.
If this is going to be seriously considered for merging then Ill spend some more time looking at it but Im not sure the project maintainers are interested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldrichksb this has now been made optional. Disabled via the modifications -> disable block inside the scenarios block.