sc2api : Update Convert CloakState #306
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the game sets flag has_cloak and send CloakState as CloakedUnknown. Conversion routine did not take it into account and returned status failure. Now unit cloak state can have value CloakedUnknown and conversion routine returns success.
peter-cudmore
added a commit
to peter-cudmore/s2client-api
that referenced
this pull request
Jul 12, 2019
Cloak now works properly
|
Aren't * _ proto _ * files supposed to be auto-generated by gRPC |
|
@minchopaskal you should be right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with receiving of the observation object (#301).
Particularly, received data is converted to unit pool in the sc2_proto_to_pods.cc file. And the conversion function checks that received data is correct and all units are in known state.
For some reason the game sets flag has_cloak and send CloakState as CloakedUnknown.
Conversion routine did not take it into account and returned status failure. So that, unit pool stays not initialized.
This request adds new cloak state CloakedUnknown and updates the conversion routine, so it returns success in such case,