Initial commit to prepare for new architecture/design #20
clippy
15 errors, 22 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 15 |
| Warning | 22 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check warning on line 59 in src/core/engine.rs
github-actions / clippy
unused variable: `fields`
warning: unused variable: `fields`
--> src/core/engine.rs:59:59
|
59 | fn log_msg<F: FieldSet>(&self, metadata: MetadataRef, fields: F) {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_fields`
Check warning on line 59 in src/core/engine.rs
github-actions / clippy
unused variable: `metadata`
warning: unused variable: `metadata`
--> src/core/engine.rs:59:36
|
59 | fn log_msg<F: FieldSet>(&self, metadata: MetadataRef, fields: F) {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metadata`
Check warning on line 53 in src/core/engine.rs
github-actions / clippy
unused variable: `fields`
warning: unused variable: `fields`
--> src/core/engine.rs:53:79
|
53 | fn section_exit<F: FieldSet>(&self, id: NonZeroU32, start: u64, end: u64, fields: F) {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_fields`
Check warning on line 53 in src/core/engine.rs
github-actions / clippy
unused variable: `end`
warning: unused variable: `end`
--> src/core/engine.rs:53:69
|
53 | fn section_exit<F: FieldSet>(&self, id: NonZeroU32, start: u64, end: u64, fields: F) {
| ^^^ help: if this is intentional, prefix it with an underscore: `_end`
Check warning on line 53 in src/core/engine.rs
github-actions / clippy
unused variable: `start`
warning: unused variable: `start`
--> src/core/engine.rs:53:57
|
53 | fn section_exit<F: FieldSet>(&self, id: NonZeroU32, start: u64, end: u64, fields: F) {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_start`
Check warning on line 53 in src/core/engine.rs
github-actions / clippy
unused variable: `id`
warning: unused variable: `id`
--> src/core/engine.rs:53:41
|
53 | fn section_exit<F: FieldSet>(&self, id: NonZeroU32, start: u64, end: u64, fields: F) {
| ^^ help: if this is intentional, prefix it with an underscore: `_id`
Check warning on line 49 in src/core/engine.rs
github-actions / clippy
unused variable: `follows`
warning: unused variable: `follows`
--> src/core/engine.rs:49:47
|
49 | fn section_follows(&self, id: NonZeroU32, follows: NonZeroU32) {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_follows`
Check warning on line 49 in src/core/engine.rs
github-actions / clippy
unused variable: `id`
warning: unused variable: `id`
--> src/core/engine.rs:49:31
|
49 | fn section_follows(&self, id: NonZeroU32, follows: NonZeroU32) {
| ^^ help: if this is intentional, prefix it with an underscore: `_id`
Check warning on line 45 in src/core/engine.rs
github-actions / clippy
unused variable: `id`
warning: unused variable: `id`
--> src/core/engine.rs:45:30
|
45 | fn section_create(&self, id: NonZeroU32) {
| ^^ help: if this is intentional, prefix it with an underscore: `_id`
Check warning on line 41 in src/core/engine.rs
github-actions / clippy
unused variable: `metadata`
warning: unused variable: `metadata`
--> src/core/engine.rs:41:32
|
41 | fn section_register(&self, metadata: MetadataRef) -> NonZeroU32 {
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_metadata`
|
= note: `#[warn(unused_variables)]` on by default
Check failure on line 47 in src/visitor.rs
github-actions / clippy
arguments to this function are incorrect
error[E0308]: arguments to this function are incorrect
--> src/visitor.rs:47:23
|
47 | let mut msg = LogMsg::new(target, tracing_level_to_log(metadata.level()));
| ^^^^^^^^^^^ ------ -------------------------------------- expected `bp3d_logger::Level`, found `log::Level`
| |
| expected `Location`, found `&str`
|
= note: `log::Level` and `bp3d_logger::Level` have similar names, but are actually distinct types
note: `log::Level` is defined in crate `log`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/log-0.4.21/src/lib.rs:439:1
|
439 | pub enum Level {
| ^^^^^^^^^^^^^^
note: `bp3d_logger::Level` is defined in crate `bp3d_logger`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bp3d-logger-2.0.0-rc.2.0.0/src/level.rs:94:1
|
94 | pub enum Level {
| ^^^^^^^^^^^^^^
note: associated function defined here
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bp3d-logger-2.0.0-rc.2.0.0/src/log_msg.rs:136:12
|
136 | pub fn new(location: Location, level: Level) -> LogMsg {
| ^^^
Check failure on line 115 in src/logger.rs
github-actions / clippy
arguments to this function are incorrect
error[E0308]: arguments to this function are incorrect
--> src/logger.rs:115:23
|
115 | let mut msg = LogMsg::new(target, tracing_level_to_log(event.metadata().level()));
| ^^^^^^^^^^^ ------ ---------------------------------------------- expected `bp3d_logger::Level`, found `log::Level`
| |
| expected `Location`, found `&str`
|
= note: `log::Level` and `bp3d_logger::Level` have similar names, but are actually distinct types
note: `log::Level` is defined in crate `log`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/log-0.4.21/src/lib.rs:439:1
|
439 | pub enum Level {
| ^^^^^^^^^^^^^^
note: `bp3d_logger::Level` is defined in crate `bp3d_logger`
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bp3d-logger-2.0.0-rc.2.0.0/src/level.rs:94:1
|
94 | pub enum Level {
| ^^^^^^^^^^^^^^
note: associated function defined here
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bp3d-logger-2.0.0-rc.2.0.0/src/log_msg.rs:136:12
|
136 | pub fn new(location: Location, level: Level) -> LogMsg {
| ^^^
Check failure on line 66 in src/logger.rs
github-actions / clippy
no method named `start` found for struct `bp3d_logger::Logger` in the current scope
error[E0599]: no method named `start` found for struct `bp3d_logger::Logger` in the current scope
--> src/logger.rs:66:27
|
66 | let guard = guard.start();
| ^^^^^ method not found in `Logger`
Check failure on line 64 in src/logger.rs
github-actions / clippy
no method named `add_file` found for struct `bp3d_logger::Logger` in the current scope
error[E0599]: no method named `add_file` found for struct `bp3d_logger::Logger` in the current scope
--> src/logger.rs:64:27
|
64 | guard = guard.add_file(app)
| ^^^^^^^^ method not found in `Logger`
Check failure on line 59 in src/logger.rs
github-actions / clippy
no method named `smart_stderr` found for struct `bp3d_logger::Logger` in the current scope
error[E0599]: no method named `smart_stderr` found for struct `bp3d_logger::Logger` in the current scope
--> src/logger.rs:59:18
|
58 | guard = guard
| _____________________-
59 | | .smart_stderr(console.get_stderr())
| | -^^^^^^^^^^^^ method not found in `Logger`
| |_________________|
|
Check failure on line 51 in src/logger.rs
github-actions / clippy
this function takes 1 argument but 0 arguments were supplied
error[E0061]: this function takes 1 argument but 0 arguments were supplied
--> src/logger.rs:51:25
|
51 | let mut guard = bp3d_logger::Logger::new();
| ^^^^^^^^^^^^^^^^^^^^^^^^-- an argument of type `bp3d_logger::Builder` is missing
|
note: associated function defined here
--> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bp3d-logger-2.0.0-rc.2.0.0/src/internal.rs:108:19
|
108 | pub(crate) fn new(builder: Builder) -> Logger {
| ^^^
help: provide the argument
|
51 | let mut guard = bp3d_logger::Logger::new(/* bp3d_logger::Builder */);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check failure on line 51 in src/logger.rs
github-actions / clippy
associated function `new` is private
error[E0624]: associated function `new` is private
--> src/logger.rs:51:46
|
51 | let mut guard = bp3d_logger::Logger::new();
| ^^^ private associated function
|
::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bp3d-logger-2.0.0-rc.2.0.0/src/internal.rs:108:5
|
108 | pub(crate) fn new(builder: Builder) -> Logger {
| --------------------------------------------- private associated function defined here
Check warning on line 29 in src/profiler/thread/store.rs
github-actions / clippy
unused import: `bytesutil::WriteExt`
warning: unused import: `bytesutil::WriteExt`
--> src/profiler/thread/store.rs:29:5
|
29 | use bytesutil::WriteExt;
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 305 in src/profiler/network_types/serializer.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> src/profiler/network_types/serializer.rs:305:34
|
305 | fn serialize_newtype_variant<T: ?Sized>(
| ^
...
313 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
Check warning on line 294 in src/profiler/network_types/serializer.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> src/profiler/network_types/serializer.rs:294:33
|
294 | fn serialize_newtype_struct<T: ?Sized>(
| ^
...
300 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
Check warning on line 269 in src/profiler/network_types/serializer.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> src/profiler/network_types/serializer.rs:269:23
|
269 | fn serialize_some<T: ?Sized>(self, value: &T) -> Result<Self::Ok, Self::Error>
| ^
270 | where
271 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
Check warning on line 181 in src/profiler/network_types/serializer.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> src/profiler/network_types/serializer.rs:181:24
|
181 | fn serialize_field<T: ?Sized>(&mut self, _: &'static str, value: &T) -> Result<(), Self::Error>
| ^
182 | where
183 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
Check warning on line 165 in src/profiler/network_types/serializer.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> src/profiler/network_types/serializer.rs:165:24
|
165 | fn serialize_field<T: ?Sized>(&mut self, _: &'static str, value: &T) -> Result<(), Self::Error>
| ^
166 | where
167 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
Check warning on line 149 in src/profiler/network_types/serializer.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> src/profiler/network_types/serializer.rs:149:24
|
149 | fn serialize_field<T: ?Sized>(&mut self, value: &T) -> Result<(), Self::Error>
| ^
150 | where
151 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
Check warning on line 133 in src/profiler/network_types/serializer.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> src/profiler/network_types/serializer.rs:133:24
|
133 | fn serialize_field<T: ?Sized>(&mut self, value: &T) -> Result<(), Self::Error>
| ^
134 | where
135 | T: Serialize,
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations