Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ColinRhys
Copy link

For issue - "Allow user to specify a fee rate"

Code Changes:

  • Added optional parameter user_fee_rate for calculate_fee function
  • If / else block checking for user_fee_rate
  • Use user_fee_rate if present
  • Added test for specific scenario of a user passing in user_fee_rate. The test checks individual rate variables in the ProjectedFees struct returned by calculate_fee. The fee should always be equal to the user_fee_rate passed in.
  • Changed function signature of calculate_fee and so added None to other places was called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant