Fix missing clears on secret values - #367
Open
mllwchrry wants to merge 1 commit into
Open
Conversation
DarkWindman
reviewed
Jul 13, 2026
DarkWindman
left a comment
DarkWindman
left a comment
Contributor
There was a problem hiding this comment.
Small nit. Everything else looks good to me!
| secp256k1_scalar_set_int(&acc, 0); | ||
| for (i = 0; i < n; i++) { | ||
| secp256k1_scalar_set_b32(&x, blinds[i], &overflow); | ||
| if (overflow) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (overflow) { | |
| secp256k1_scalar_clear(&acc); | |
| secp256k1_scalar_clear(&x); | |
| return 0; | |
| } |
mllwchrry
force-pushed
the
fix-missing-scalar-clear
branch
from
July 13, 2026 15:08
a9b681b to
e760fec
Compare
Contributor
|
ACK e760fec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several zkp module functions leave secret scalars and buffers live on the stack after use.
Adds the missing clears. Also removes a redundant
prepclear insecp256k1_rangeproof_sign_implthat was already cleared earlier on the same path.