-
Notifications
You must be signed in to change notification settings - Fork 29
WIP Segfault with variable-width strings #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Unsure why CI is not being triggered? |
Because there is not a proper CI set yet (we typically test this plugin manually with PyTables). Would you like to provide one? Also, I don't see the fix in the PR (apparently it was reverted in a commit?). Also missing the PR for the hdf5-blosc2 plugin. |
Yes, happy to work on it.
Yes, I'm working on it.
Also working on it. It's the same problem. |
83c52f8 to
f537f9f
Compare
| const char* complist; | ||
| char errmsg[256]; | ||
|
|
||
| assert(cd_nelmts >= 4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_strings crashes here if you remove the workaround hack from it. blosc_set_local did not run so this is valued 0.
a906df9 to
57c53b2
Compare
The filter segfaults when faced with char** data.
Working on a fix. The current PR demonstrates the problem (uncomment
H5Pset_filterto trigger the segfault).XREF silx-kit/hdf5plugin#364