Include <cstdint> for fixed-width integers in API headers #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least in the API headers, include <cstdint> everywhere that fixed-width integer types `int32_t`, `uint32_t`, or `uint64_t` are used. Including headers everywhere they are used avoids relying on indirectly including them via the C++ standard library, which tends to break with new compiler versions. This change doesn’t implement that idea project-wide even for `<cstdint>`, let alone in general, but it is enough to fix failure to build with GCC 15.
matz-e
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thanks! BTW, I think that future development of this has moved into the @openbraininstitute organization?
Yes, it is now https://github.com/openbraininstitute/morphio @eleftherioszisis |
Ah, thank you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least in the API headers, include
<cstdint>everywhere that fixed-width integer typesint32_t,uint32_t, oruint64_tare used. Including headers everywhere they are used avoids relying on indirectly including them via the C++ standard library, which tends to break with new compiler versions. This change doesn’t implement that idea project-wide even for<cstdint>, let alone in general, but it is enough to fix failure to build with GCC 15 (as observed in Fedora).