fix stm32f4 DMA access not working - #3916
Open
mtc-creations wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses STM32F4 (and the shared STM32F2/F4/F7 path) SPI DMA transfers failing due to the STM32 HAL SPI handle (spiHal) not being in a READY state when HAL_SPI_Transmit_DMA is first used.
Changes:
- Set
spiHal.State = HAL_SPI_STATE_READYduringTFT_eSPI::initDMA()for STM32F2xx/F4xx/F7xx, mirroring the existing STM32L4 behavior. - Add an explanatory comment describing why the state must be set for DMA to work.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stm32f4 DMA wouldnt work for me (screen blank) without this fix.
This is a copy of the existing code at Line 719 for the STM32L4, seems like the STM32F4 needs it aswell.