Skip to content

fix: normalize response bytes in getKeysFromRelayer #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luchobonatti wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: normalize response bytes in getKeysFromRelayer #2

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dec9d8
fix: normalize response bytes in getKeysFromRelayer
luchobonatti Apr 8, 2026
827316a
fix: remove redundant Uint8Array clone on CRS bytes
luchobonatti Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions src/relayer-provider/v1/networkV1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
} from '@sdk/lowlevel/constants';
import { fetchRelayerV1Get } from './fetchRelayerV1';
import { isNonEmptyString, removeSuffix } from '@base/string';
import { getResponseBytes } from '@base/fetch';

// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
type CachedKey = {
Expand Down Expand Up @@ -77,13 +78,7 @@ export async function getKeysFromRelayer(
);
}

let publicKey: Uint8Array;
if (typeof publicKeyResponse.bytes === 'function') {
// bytes is not widely supported yet
publicKey = await publicKeyResponse.bytes();
} else {
publicKey = new Uint8Array(await publicKeyResponse.arrayBuffer());
}
const publicKey = await getResponseBytes(publicKeyResponse);

const publicParamsUrl = data.response.crs['2048'].urls[0];
const publicParamsId = data.response.crs['2048'].data_id;
Expand All @@ -95,15 +90,7 @@ export async function getKeysFromRelayer(
);
}

let publicParams2048: Uint8Array;
if (typeof publicParams2048Response.bytes === 'function') {
// bytes is not widely supported yet
publicParams2048 = await publicParams2048Response.bytes();
} else {
publicParams2048 = new Uint8Array(
await publicParams2048Response.arrayBuffer(),
);
}
const publicParams2048 = await getResponseBytes(publicParams2048Response);
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getResponseBytes() already returns a Uint8Array, but later this buffer is wrapped with new Uint8Array(publicParams2048) before deserialization. That constructor call will clone the entire CRS byte array, which can be very large and adds avoidable memory/CPU overhead. Since the bytes are already normalized, pass publicParams2048 directly to CompactPkeCrs.safe_deserialize(...) (and drop the extra new Uint8Array(...)).

Copilot uses AI. Check for mistakes.

let pub_key;
try {
Expand Down