feat(Holiday): update holiday data for 2026 #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Please double-check that the new
2026.jsonis wired into the.csprojin the same way as the existing holiday data files (e.g., build action, copy settings, and item group structure) to avoid inconsistent behavior at runtime. - Ensure the structure and key names in
Data/2026.jsonmatch the previous years’ JSON files so that the Holiday component can parse the new data without additional code changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please double-check that the new `2026.json` is wired into the `.csproj` in the same way as the existing holiday data files (e.g., build action, copy settings, and item group structure) to avoid inconsistent behavior at runtime.
- Ensure the structure and key names in `Data/2026.json` match the previous years’ JSON files so that the Holiday component can parse the new data without additional code changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR adds Chinese holiday data for the year 2026 to the BootstrapBlazor.Holiday component and bumps the package version to 10.0.1. The new data file follows the established JSON structure used for previous years (2016-2025) and includes major Chinese holidays with their respective dates, holiday periods, and make-up working days.
- Adds 2026.json with holiday and working day definitions for all major Chinese holidays
- Increments package version from implicit to explicit 10.0.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/BootstrapBlazor.Holiday/Data/2026.json | New holiday data file for 2026 containing Chinese holiday schedules including Spring Festival, Qingming, Labor Day, Dragon Boat Festival, Mid-Autumn Festival, and National Day with their associated make-up working days |
| src/components/BootstrapBlazor.Holiday/BootstrapBlazor.Holiday.csproj | Adds explicit version property set to 10.0.1, appropriate for a minor content update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+64
| "range": [ "2026-01-01", "2026-01-03" ], | ||
| "type": "holiday" | ||
| }, | ||
| { | ||
| "name": "元旦", | ||
| "range": [ "2026-01-04" ], | ||
| "type": "workingday" | ||
| }, | ||
| { | ||
| "name": "春节", | ||
| "range": [ "2026-02-14" ], | ||
| "type": "workingday" | ||
| }, | ||
| { | ||
| "name": "春节", | ||
| "range": [ "2026-02-15", "2026-02-23" ], | ||
| "type": "holiday" | ||
| }, | ||
| { | ||
| "name": "春节", | ||
| "range": [ "2026-02-28" ], | ||
| "type": "workingday" | ||
| }, | ||
| { | ||
| "name": "清明节", | ||
| "range": [ "2026-04-04", "2026-04-06" ], | ||
| "type": "holiday" | ||
| }, | ||
| { | ||
| "name": "劳动节", | ||
| "range": [ "2026-05-01", "2026-05-05" ], | ||
| "type": "holiday" | ||
| }, | ||
| { | ||
| "name": "劳动节", | ||
| "range": [ "2026-05-09" ], | ||
| "type": "workingday" | ||
| }, | ||
| { | ||
| "name": "端午节", | ||
| "range": [ "2026-06-19", "2026-06-21" ], | ||
| "type": "holiday" | ||
| }, | ||
| { | ||
| "name": "中秋节", | ||
| "range": [ "2026-09-20" ], | ||
| "type": "workingday" | ||
| }, | ||
| { | ||
| "name": "中秋节", | ||
| "range": [ "2026-09-25", "2026-09-27" ], | ||
| "type": "holiday" | ||
| }, | ||
| { | ||
| "name": "国庆节", | ||
| "range": [ "2026-10-01", "2026-10-07" ], | ||
| "type": "holiday" | ||
| }, | ||
| { | ||
| "name": "国庆节", | ||
| "range": [ "2026-10-10" ], |
There was a problem hiding this comment.
The array formatting in the "range" fields is inconsistent with the existing data files. All other year files (2016-2025) use compact array notation without spaces, e.g., ["2025-01-01", "2025-01-03"], but this file uses spaces inside the brackets, e.g., [ "2026-01-01", "2026-01-03" ].
For consistency with the established codebase convention, remove the spaces after the opening bracket and before the closing bracket in all "range" arrays throughout this file.
Suggested change
| "range": [ "2026-01-01", "2026-01-03" ], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "元旦", | |
| "range": [ "2026-01-04" ], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "春节", | |
| "range": [ "2026-02-14" ], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "春节", | |
| "range": [ "2026-02-15", "2026-02-23" ], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "春节", | |
| "range": [ "2026-02-28" ], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "清明节", | |
| "range": [ "2026-04-04", "2026-04-06" ], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "劳动节", | |
| "range": [ "2026-05-01", "2026-05-05" ], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "劳动节", | |
| "range": [ "2026-05-09" ], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "端午节", | |
| "range": [ "2026-06-19", "2026-06-21" ], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "中秋节", | |
| "range": [ "2026-09-20" ], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "中秋节", | |
| "range": [ "2026-09-25", "2026-09-27" ], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "国庆节", | |
| "range": [ "2026-10-01", "2026-10-07" ], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "国庆节", | |
| "range": [ "2026-10-10" ], | |
| "range": ["2026-01-01", "2026-01-03"], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "元旦", | |
| "range": ["2026-01-04"], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "春节", | |
| "range": ["2026-02-14"], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "春节", | |
| "range": ["2026-02-15", "2026-02-23"], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "春节", | |
| "range": ["2026-02-28"], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "清明节", | |
| "range": ["2026-04-04", "2026-04-06"], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "劳动节", | |
| "range": ["2026-05-01", "2026-05-05"], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "劳动节", | |
| "range": ["2026-05-09"], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "端午节", | |
| "range": ["2026-06-19", "2026-06-21"], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "中秋节", | |
| "range": ["2026-09-20"], | |
| "type": "workingday" | |
| }, | |
| { | |
| "name": "中秋节", | |
| "range": ["2026-09-25", "2026-09-27"], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "国庆节", | |
| "range": ["2026-10-01", "2026-10-07"], | |
| "type": "holiday" | |
| }, | |
| { | |
| "name": "国庆节", | |
| "range": ["2026-10-10"], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #884
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update holiday component data files to include holidays for the year 2026.
New Features:
Enhancements: