-
-
Notifications
You must be signed in to change notification settings - Fork 6
feat(BaiduSpeech): remove HttpClient MemoryCache services inject #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the BaiduSpeech component DI setup by no longer registering HttpClient and MemoryCache directly in its AddBootstrapBlazorBaiduSpeech extension, leaving only the Baidu speech-specific services to be wired up. Class diagram for updated BaiduSpeech DI extensionclassDiagram
class ServiceCollectionExtension {
+IServiceCollection AddBootstrapBlazorBaiduSpeech(IServiceCollection services, Action_BaiduSpeechOption configOptions)
}
class IServiceCollection
class RecognizerService
class IRecognizerProvider
class BaiduRecognizerProvider
IServiceCollection <|.. ServiceCollectionExtension
IServiceCollection o--> RecognizerService : scoped
IServiceCollection o--> IRecognizerProvider : scoped
IRecognizerProvider <|.. BaiduRecognizerProvider
class BaiduSpeechOption
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes unnecessary service registrations (AddHttpClient() and AddMemoryCache()) from the BaiduSpeech component's dependency injection setup and bumps the version from 10.0.1 to 10.0.2.
- Removes
AddHttpClient()andAddMemoryCache()calls that are not required by the BaiduSpeech component - Updates package version to 10.0.2
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ServiceCollectionExtension.cs | Removes unnecessary HttpClient and MemoryCache service registrations from the BaiduSpeech DI configuration |
| BootstrapBlazor.BaiduSpeech.csproj | Increments package version from 10.0.1 to 10.0.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Link issues
fixes #890
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: