Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 7, 2026

Link issues

fixes #890

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Stop registering HttpClient and memory cache within the BaiduSpeech service extension so these dependencies can be managed by the host application.

Copilot AI review requested due to automatic review settings January 7, 2026 00:53
@bb-auto bb-auto bot added the enhancement New feature or request label Jan 7, 2026
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 7, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 7, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the BaiduSpeech component DI setup by no longer registering HttpClient and MemoryCache directly in its AddBootstrapBlazorBaiduSpeech extension, leaving only the Baidu speech-specific services to be wired up.

Class diagram for updated BaiduSpeech DI extension

classDiagram
    class ServiceCollectionExtension {
        +IServiceCollection AddBootstrapBlazorBaiduSpeech(IServiceCollection services, Action_BaiduSpeechOption configOptions)
    }

    class IServiceCollection

    class RecognizerService

    class IRecognizerProvider
    class BaiduRecognizerProvider

    IServiceCollection <|.. ServiceCollectionExtension
    IServiceCollection o--> RecognizerService : scoped
    IServiceCollection o--> IRecognizerProvider : scoped
    IRecognizerProvider <|.. BaiduRecognizerProvider

    class BaiduSpeechOption
Loading

File-Level Changes

Change Details Files
Stop registering HttpClient and MemoryCache in the BaiduSpeech service extension and limit DI configuration to Baidu speech-specific services.
  • Remove AddHttpClient() registration from the BaiduSpeech IServiceCollection extension method.
  • Remove AddMemoryCache() registration from the BaiduSpeech IServiceCollection extension method.
  • Keep RecognizerService and IRecognizerProvider/BaiduRecognizerProvider registrations unchanged.
src/components/BootstrapBlazor.BaiduSpeech/Extensions/ServiceCollectionExtension.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#890 Remove HttpClient and MemoryCache service registrations from the BaiduSpeech service collection extension (AddBootstrapBlazorBaiduSpeech).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 999eacc into master Jan 7, 2026
5 of 6 checks passed
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang deleted the dev-speech branch January 7, 2026 00:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unnecessary service registrations (AddHttpClient() and AddMemoryCache()) from the BaiduSpeech component's dependency injection setup and bumps the version from 10.0.1 to 10.0.2.

  • Removes AddHttpClient() and AddMemoryCache() calls that are not required by the BaiduSpeech component
  • Updates package version to 10.0.2

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ServiceCollectionExtension.cs Removes unnecessary HttpClient and MemoryCache service registrations from the BaiduSpeech DI configuration
BootstrapBlazor.BaiduSpeech.csproj Increments package version from 10.0.1 to 10.0.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(BaiduSpeech): remove HttpClient MemoryCache services inject

2 participants