Skip to content

fix(PdfReader): prevent render twice when url is null #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArgoZhang merged 2 commits into from
Jan 10, 2026
Merged

fix(PdfReader): prevent render twice when url is null #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a46dbbf
fix(PdfReader): prevent rendering twice
ArgoZhang Jan 10, 2026
dbd282b
chore: bump version 10.0.26
ArgoZhang Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/BootstrapBlazor.PdfReader/BootstrapBlazor.PdfReader.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>10.0.25</Version>
<Version>10.0.26</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/components/BootstrapBlazor.PdfReader/PdfReader.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ protected override async Task OnAfterRenderAsync(bool firstRender)
_showToolbar = ShowToolbar;
_enableThumbnails = EnableThumbnails;
_fitMode = FitMode;
return;
Copy link

Copilot AI Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug fix prevents double rendering when Url is null, but there are no automated tests to verify this behavior. Consider adding unit tests for the PdfReader component to ensure this issue doesn't regress in the future, especially for the OnAfterRenderAsync lifecycle method with various Url states.

Copilot uses AI. Check for mistakes.
}

if (_url != Url)
Expand Down
Loading