feat: add decode_xpub tool#30
Closed
ThomsenDrake wants to merge 3 commits into
Closed
Conversation
Implements the bitcoin://fees/history resource from issue Bortlesboat#3, returning a 7-day hourly fee rate time-series from the Satoshi API indexed endpoint. Changes: - Add resource_fees_history() using /api/v1/fees/history endpoint - Returns period, hourly buckets (timestamp, fast/medium/slow sat/vB), 7d stats - Graceful fallback when indexed API is unavailable (502, timeout, etc.) - Add test_resource_fees_history_success (mocks API response) - Add test_resource_fees_history_api_error_fallback (mocks 502 error) Tested: 126 tests passing (full suite).
Implements bitcoin-mcp issue Bortlesboat#2. - Accepts xpub/ypub/zpub/tpub and returns network, key type, fingerprint, depth, and derived addresses with BIP-32 paths - Uses Bitcoin Core getdescriptorinfo + deriveaddresses RPCs - Falls back to Satoshi API when no local node is available - Explicitly rejects extended private keys (xprv etc.) - Clamp derive_count to [1, 20] range - 7 new tests covering error cases and descriptor construction - Tool is watch-only: never processes private key material
Contributor
Author
|
👋 Bortlesboat — PR #29 merged, thank you! This is the follow-up for issue #2 (decode_xpub). Implements a tool that:
No urgency — just here when you're ready for review. Happy to address any feedback. |
Owner
|
Closing this as superseded by #31, which consolidates the open backlog work into one maintainer sweep. Thank you for the contribution and the concrete issue coverage here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements issue #2. Adds decode_xpub tool that derives addresses from xpub/ypub/zpub/tpub using Bitcoin Core descriptor RPCs.