Merged
Conversation
Collaborator
tipatterson-dev
commented
Oct 8, 2025
- Add improved support for MQTT
- Clean up a few top level functions for clarity
- implement more async routines for performance
- begin codebase reorganization for planned UX improvements
- reorganization of major files
- update some URl construction methods
There was a problem hiding this comment.
Pull Request Overview
This PR implements improved MQTT support and begins a significant codebase reorganization. It introduces a new streamable resource architecture, consolidates data models, and cleans up the module structure for planned UX improvements.
- Introduces new streamable resource system with websocket and MQTT connectivity
- Consolidates scattered data models into unified modules
- Removes numerous deprecated API helper modules and restructures imports
Reviewed Changes
Copilot reviewed 46 out of 55 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/oshconnect/streamableresource.py | New comprehensive module implementing the streamable resource architecture with Node, System, Datastream classes |
| src/oshconnect/schema_datamodels.py | Consolidated schema data models from multiple scattered modules |
| src/oshconnect/resource_datamodels.py | Unified resource data models replacing core_datamodels.py |
| tests/ | Updated test files with new import paths and test structure |
| src/oshconnect/csapi4py/ | Various updates to API helpers and MQTT client improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.