Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of oxDNA Files #346

Merged
merged 26 commits into from
Nov 22, 2023
Merged

Import of oxDNA Files #346

merged 26 commits into from
Nov 22, 2023

Conversation

BradyAJohnston
Copy link
Owner

@BradyAJohnston BradyAJohnston commented Nov 20, 2023

Adds initial support for importing oxDNA files. Expects a topology and trajectory file to import. The trajectory is often a single frame, where a single topology object will be created. If the trajectory contains multiple frames, then a frames collection containing each frame of the trajectory will be imported, enabling playback of the animation through Molecular Nodes.

Tasks:

  • Support old topology
  • Support new topology
  • properly align with base_normal / base_vector
  • multi-frame trajectory import
  • trajectory bounding box wrapping

Example trajectory (from here) rendered below, loading in a 5.5 GB trajectory file and 3.8 MB topology file results in ~800 MB .blend file.

origami_trajectory.mp4

The stand ID is labelled as chain_id to fit with the rest of Molecular Nodes. Bases are converted to their numeric representations and stored as res_name. Using the position, base_vector and base_normal you can instance bases on the DNA, either as simple cylinders or their different representations:
CleanShot 2023-11-20 at 11 59 54@2x

A simple Points to Curves node can turn the 'backbones' into the cuves of the DNA.

Build for import oxdna files:

MolecularNodes_oxDNA.zip

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (4.0@7fe7687). Click here to learn what that means.

❗ Current head 7db55f7 differs from pull request most recent head 5bdaf87. Consider uploading reports for the commit 5bdaf87 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             4.0     #346   +/-   ##
======================================
  Coverage       ?   69.94%           
======================================
  Files          ?       24           
  Lines          ?     3081           
  Branches       ?        0           
======================================
  Hits           ?     2155           
  Misses         ?      926           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyAJohnston BradyAJohnston changed the base branch from main to 4.0 November 22, 2023 09:23
@BradyAJohnston BradyAJohnston merged commit 5bdaf87 into 4.0 Nov 22, 2023
@BradyAJohnston BradyAJohnston deleted the dev-origami branch November 28, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant