Skip to content

[BUG] 응답값으로 null 나오는 버그 수정 + 공개프로필 조회 시 @PathVariable로 변경 #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dongjune8931 merged 2 commits into from
Feb 9, 2025
Merged

[BUG] 응답값으로 null 나오는 버그 수정 + 공개프로필 조회 시 @PathVariable로 변경 #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984a622
[BUG] 응답값 추가로 인한 null 해결.
dongjune8931 Feb 9, 2025
2aeea84
[BUG] @UserId -> @PathVariable 수정
dongjune8931 Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/brainpix/profile/controller/PublicProfileController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import org.springframework.data.web.PageableDefault;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;

Expand All @@ -16,7 +17,6 @@
import com.brainpix.profile.dto.PublicProfileResponseDto;
import com.brainpix.profile.service.PublicProfileService;
import com.brainpix.security.authorization.AllUser;
import com.brainpix.security.authorization.UserId;

import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.tags.Tag;
Expand All @@ -37,7 +37,7 @@ public class PublicProfileController {
@Operation(summary = "개인 공개 프로필 조회", description = "특정 사용자에게 공개 개인 프로필을 조회합니다.")
@GetMapping("/individual")
public ResponseEntity<ApiResponse<IndividualProfileResponseDto>> getPublicIndividualProfile(
@UserId Long userId) {
@PathVariable Long userId) {
IndividualProfileResponseDto profile = publicProfileService.getPublicIndividualProfile(userId);
return ResponseEntity.ok(ApiResponse.success(profile));
}
Expand All @@ -48,7 +48,7 @@ public ResponseEntity<ApiResponse<IndividualProfileResponseDto>> getPublicIndivi
@AllUser
@Operation(summary = "기업 공개 프로필 조회", description = "특정 사용자에게 공개 기업 프로필을 조회합니다.")
@GetMapping("/company")
public ResponseEntity<ApiResponse<CompanyProfileResponseDto>> getPublicCompanyProfile(@UserId Long userId) {
public ResponseEntity<ApiResponse<CompanyProfileResponseDto>> getPublicCompanyProfile(@PathVariable Long userId) {
CompanyProfileResponseDto profile = publicProfileService.getPublicCompanyProfile(userId);
return ResponseEntity.ok(ApiResponse.success(profile));
}
Expand All @@ -58,7 +58,7 @@ public ResponseEntity<ApiResponse<CompanyProfileResponseDto>> getPublicCompanyPr
@GetMapping
@SwaggerPageable
public ResponseEntity<ApiResponse<CommonPageResponse<PublicProfileResponseDto.PostPreviewDto>>> getPostsByUser(
@UserId Long userId,
@PathVariable Long userId,
@PageableDefault(sort = "createdDate", direction = Sort.Direction.DESC) Pageable pageable) {
CommonPageResponse<PublicProfileResponseDto.PostPreviewDto> pageResponse =
CommonPageResponse.of(publicProfileService.getPostsByUser(userId, pageable));
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/brainpix/profile/converter/MyProfileConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public IndividualProfileResponseDto toDto(User user) {
.map(contact -> IndividualProfileResponseDto.ContactDto.builder()
.type(contact.getType())
.value(contact.getValue())
.isPublic(contact.getIsPublic())
.build())
.toList())
.stacks(profile.getStacks().stream()
Expand Down