Skip to content

feat: add overpayment confirmation dialog and fix closing shift recon…#187

Merged
engahmed1190 merged 1 commit intodevelopfrom
feature/overpayment-confirm-and-closing-shift-fixes
Mar 11, 2026
Merged

feat: add overpayment confirmation dialog and fix closing shift recon…#187
engahmed1190 merged 1 commit intodevelopfrom
feature/overpayment-confirm-and-closing-shift-fixes

Conversation

@engahmed1190
Copy link
Copy Markdown
Contributor

…ciliation

  • Add nested Radix Dialog for large overpayment warning in PaymentDialog (triggers when change exceeds invoice total, works reliably with pointer events)
  • Consolidate duplicate payment entries via _upsertPaymentEntry
  • Fix closing shift change_amount double-subtraction (once per invoice, not per payment row)
  • Skip credit returns (no payment rows) from shift totals
  • Remap foreign payment modes on cross-branch return invoices to cash mode

…ciliation

- Add nested Radix Dialog for large overpayment warning in PaymentDialog
  (triggers when change exceeds invoice total, works reliably with pointer events)
- Consolidate duplicate payment entries via _upsertPaymentEntry
- Fix closing shift change_amount double-subtraction (once per invoice, not per payment row)
- Skip credit returns (no payment rows) from shift totals
- Remap foreign payment modes on cross-branch return invoices to cash mode

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@engahmed1190 engahmed1190 merged commit e139b51 into develop Mar 11, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant