Mitigate 404s for nexus_demo banner and improve customer dialog#288
Merged
Conversation
Add onerror="this.remove()" to the demo countdown banner <link> and <script> tags in POS/index.html so the orphan nodes drop out of the DOM when the nexus_demo app is not installed on the bench. Prevents stale references and keeps the SPA shell clean on benches that ship pos_next without nexus_demo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…mitigation fix(spa): mitigate nexus_demo banner 404s in POSNext shell
… unnecessary console log
fix: improve customer dialog behavior by adding nextTick and removing unnecessary console log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.