update puppeteersharp #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boarnoah
approved these changes
Aug 21, 2025
Member
boarnoah
left a comment
boarnoah
left a comment
There was a problem hiding this comment.
Mind adding a bit more detail in description (so it ends up in commit msg) from the thread.
Ex: how this hardkoded/puppeteer-sharp#2924 was the bug/fix that updating PuppeteerSharp is helping us solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We are seeing passwordless auth failing and likely is related to this change here hardkoded/puppeteer-sharp#2924 . Bumping the version that includes this change should be enough
Ticket
VUL-3643