Add a vdiff demonstrating delayed content #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dlockhart
commented
Jan 14, 2025
| const el = await fixture( | ||
| `<d2l-dialog title-text="Delayed Dialog"><${delayedTag}></${delayedTag}></d2l-dialog>`, | ||
| { | ||
| awaitLoadingComplete: false |
There was a problem hiding this comment.
This is a special configuration option because otherwise the fixture call itself would wait for all the descendants to be loading-complete. In this case, we want to bypass that since we want to make sure that dialog itself waits for them.
|
Weirdly getting flake with this that I'm not seeing locally -- amazing. Will investigate tomorrow. |
bearfriend
approved these changes
Jan 15, 2025
dlockhart
force-pushed
the
GAUD-7397/vdiff
branch
from
5d9381f to
5f082b9
Compare
|
🎉 This PR is included in version 3.79.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to the changes in #5306 that adds an initially-failing vdiff test to demonstrate the problem. Once resolved, this will "go green".