fix: silence CI build warnings and resolve all SwiftLint annotations

[BrunoCerberus]

Summary

• Exclude __Snapshots__ directories from the PulseSnapshotTests target resources, eliminating libpng 16-bit PNG warnings during CI builds
• Resolve all 10 SwiftLint annotations reported on CI:
  • HomeView.swift: Trim verbose docstring (401 → 385 lines, under 400 limit)
  • CachingNewsService/CachingMediaService: Extract serveStaleData() and fetchFromNetwork() helpers from fetchWithTieredCache (under 50-line limit)
  • HomeDomainInteractor: Use Optional.map to reduce cyclomatic complexity (11 → under 10)
  • 5 CachingNewsService test files: Break 141-char init lines into multi-line format (under 120 limit)
  • APIContractTests: Split SupabaseAPIContractTests struct (251 → under 250 lines)

Context

CI runs showed 10 SwiftLint warning annotations on every PR and 2 libpng warnings during builds. The test job failures (Unit Tests artifact upload ENOTFOUND, UI Tests signal abrt crash) are GitHub Actions infrastructure issues unrelated to this change.

Test plan

• All 2224 unit tests pass (266 suites)
• All 236 snapshot tests pass
• make lint passes with 0 violations
• make build succeeds

🤖 Generated with Claude Code

[claude]

Claude finished @BrunoCerberus's task in 1m 9s —— View job

---

PR Review: Exclude snapshot reference PNGs from build

• Gather context and review the diff
• Verify consistency with existing exclusion patterns
• Post review feedback

Review Summary

Approved — This is a clean, well-scoped fix.

What it does: Adds an excludes: ["**/__Snapshots__/**"] entry to the PulseSnapshotTests target in project.yml (lines 233–234), mirroring the identical exclusion already present on the main Pulse target (line 82–83).

Why it's correct:

• SnapshotTesting locates reference images via #file at the filesystem level — it never loads them from the test bundle, so bundling the PNGs as resources is unnecessary overhead.
• The 16-bit Display P3 PNGs in FeaturedMediaCardAccessibilitySnapshotTests/__Snapshots__/ were triggering libpng warning: Input PNG does not have an 8 bit input depth during the Xcode copy-resources build phase. Excluding them eliminates the warnings at the source.
• The glob pattern **/__Snapshots__/** is consistent with the existing convention used by the Pulse app target.

No issues found — no bugs, no security concerns, no performance regressions. The change is minimal (2 lines added) and purely a build configuration improvement.

[claude]

LGTM — clean, minimal fix that correctly mirrors the existing __Snapshots__ exclusion from the main Pulse target (line 83).

[claude]

Claude finished @BrunoCerberus's task in 2m 40s —— View job

---

PR Review: fix/exclude-snapshot-pngs-from-build

• Gather context and review the full diff
• Analyze caching service refactoring
• Analyze HomeDomainInteractor and remaining changes
• Post review feedback

Review Summary

Approved — Clean PR with two well-scoped commits across 11 files.

---

Commit 1 (03e400f): Exclude snapshot PNGs from build

• Adds excludes: ["**/__Snapshots__/**"] to PulseSnapshotTests in project.yml (line 233–234), matching the identical exclusion on the main Pulse target
• Correct fix — SnapshotTesting reads reference images via #file from the filesystem, not from the bundle

Commit 2 (6a70267): Resolve SwiftLint CI annotations — 10 files changed with clean refactoring:

File	Change	Assessment
CachingNewsService.swift	Extract serveStaleData() and fetchFromNetwork() into private methods	Reduces fetchWithTieredCache complexity; no behavior change
CachingMediaService.swift	Same extraction pattern	Keeps both caching services structurally consistent
HomeDomainInteractor.swift	Replace if let article = find(...) { action(article) } with find(...).map(action)	More idiomatic Swift; Optional.map with void-returning closures is safe (no unused-result warning for Void?)
HomeView.swift	Remove verbose doc comment block	Eliminates redundant documentation that restated obvious functionality
APIContractTests.swift	Split SupabaseAPIContractTests into a separate SupabaseArticleMappingContractTests suite	Better test organization; the new suite gets its own decoder property
5 CachingNewsService*Tests.swift	Multi-line formatting for CachingNewsService init calls	Line length compliance

No issues found

• No bugs or behavioral regressions
• No security concerns
• No performance impact
• Caching service refactoring is purely structural — the tiered cache flow (L1 → L2 → offline stale → network fetch → stale fallback) is preserved exactly

[claude]

LGTM — both commits are clean and correct. See inline comment for full review.

[claude]

Claude finished @BrunoCerberus's task in 2m 34s —— View job

---

PR Review: fix/exclude-snapshot-pngs-from-build

• Gather context and review the full diff (25 files, 3 commits)
• Review CI workflow changes
• Review caching service refactoring and SwiftLint fixes
• Review UI test changes (Xcode 26 C++ exception crash fix)
• Post review feedback

Review Summary

Approved — Three well-scoped commits across 25 files. No bugs, no security concerns, no behavioral regressions.

---

Commit 1 (03e400f): Exclude snapshot PNGs from build

Adds excludes: ["**/__Snapshots__/**"] to PulseSnapshotTests in project.yml, matching the identical exclusion on the main Pulse target. Correct fix — SnapshotTesting reads reference images via #file from the filesystem, never from the bundle.

Commit 2 (6a70267): Resolve SwiftLint CI annotations

File	Change	Assessment
CachingNewsService.swift	Extract serveStaleData() and fetchFromNetwork() helpers	Purely structural; tiered cache flow (L1→L2→offline stale→network→stale fallback) preserved exactly
CachingMediaService.swift	Same extraction pattern	Keeps both caching services structurally consistent
HomeDomainInteractor.swift	if let x = find(...) { action(x) } → find(...).map(action)	Idiomatic Swift; Optional.map with Void-returning closures is safe — Void? result is silently discarded in switch cases
HomeView.swift	Remove verbose doc comment	Eliminates 16 lines of redundant documentation restating obvious functionality
APIContractTests.swift	Split SupabaseAPIContractTests into separate SupabaseArticleMappingContractTests suite	Better test organization; new suite gets its own decoder property
5 CachingNewsService test files	Multi-line formatting for init calls	Line length compliance (141→120 chars)

Commit 3 (9399586): Eliminate Xcode 26 C++ exception crashes in UI tests

This is the substantive commit. It addresses the SIGABRT crashes caused by Xcode 26's internal snapshot comparison loop in waitForExistence(timeout:).

safeWaitForExistence (BaseUITestCase.swift):

• Polls .exists (single accessibility snapshot) with 0.25s RunLoop-based delays
• Avoids XCTest's internal snapshot loop that throws uncatchable C++ exceptions
• Added as both an XCUIElement extension (line 11–21, for drop-in replacement in test files) and a BaseUITestCase instance method (line 410–418, for base class usage)

tearDown refactoring:

• Wraps app.terminate() in XCTExpectFailure instead of relying on continueAfterFailure = true — absorbs the Xcode 26 framework error annotation without crashing, preventing cascade failures
• Bumps termination wait timeout from 10s → 15s for CI shared runners

UI test files (12 files):

• Replaces all waitForExistence(timeout:) calls with safeWaitForExistence(timeout:)
• Replaces isHittable guards with coordinate(withNormalizedOffset:).tap() — avoids hittability evaluation that can also crash on iOS 26 Liquid Glass

CI workflow:

• Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true env var to suppress Node.js 20 deprecation warnings

Minor suggestion

The safeWaitForExistence logic is duplicated between the XCUIElement extension (BaseUITestCase.swift:13) and the BaseUITestCase instance method (BaseUITestCase.swift:410). The instance method could delegate to the extension to reduce duplication:

func safeWaitForExistence(_ element: XCUIElement, timeout: TimeInterval) -> Bool {
    element.safeWaitForExistence(timeout: timeout)
}

Not a blocker — both serve different call-site ergonomics and the logic is trivial.

[claude]

LGTM — Three clean, well-scoped commits. The safeWaitForExistence polling approach is a good workaround for the Xcode 26 C++ exception issue, and the caching service refactoring is purely structural with no behavioral changes. See inline comment for a minor duplication nit.