Refactor#2
Merged
Merged
Conversation
TreemanKing
requested changes
Jul 25, 2025
| public class PlayerListener implements Listener { | ||
|
|
||
| @EventHandler(priority = EventPriority.MONITOR) // Checks if other plugins are using the event | ||
| @EventHandler(priority = EventPriority.HIGHEST) |
Contributor
There was a problem hiding this comment.
Requires to be monitor as if it's on highest, it may override claim plugins
|
|
||
| dependencies { | ||
| compileOnly("de.tr7zw:item-nbt-api-plugin:2.15.1") | ||
| compileOnly("dev.jorel:commandapi-bukkit-core:10.0.1") |
Contributor
There was a problem hiding this comment.
we should be putting all dependencies into the plugin. NBTAPI and COMMANDAPI should be shaded
Contributor
Author
There was a problem hiding this comment.
These are not shaded for ItemAttributes either, it seems like a waste to shade it in multiple places.
| for (String msg : send) { | ||
| if (sendInChat) { | ||
| ChatUtils.sendMsg(player, SellstickConfig.nothingWorth, true); | ||
| ChatUtils.sendMsg(player, msg |
Contributor
There was a problem hiding this comment.
is there a reason why all the chat stuff is handled here rather than a Utils class?
Contributor
Author
There was a problem hiding this comment.
The chat/action bar handling could fit into ChatUtils but there wasn't enough repetition to justify it.
Contributor
There was a problem hiding this comment.
Future possible features?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved to gradle.
Moved to CommandAPI.
Rewrote a lot of functions, removed redundant functions and classes.