feat: add personal builders page #30
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
melanke
left a comment
melanke
left a comment
There was a problem hiding this comment.
Thanks for your page :)
I'd like to ask you to improve your PR's description:
- Please link the issue in the PR description. You can do this using
#followed by the issue number.
And here comes my review. Things I think you should improve in your code:
| import { GithubIcon, TwitterIcon } from "./icons"; | ||
| import { Address } from "@scaffold-ui/components"; | ||
|
|
||
| export default function Page() { |
There was a problem hiding this comment.
Please name your page with something more unique, like your name or nickname.
And you might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page.
packages/nextjs/app/builders/0x0ed3f043ad4fe71d00de45f6077b022576c4b86b/page.tsx
Outdated
Show resolved
Hide resolved
|
Hey! I noticed your profile page path is using the Ethereum address in all lowercase. Could you update it to the checksummed version? Using EIP-55 casing is the standard and makes it easier to spot typos, which helps avoid mistakes when someone copies or validates the address. Thanks! (0x0eD3f043ad4Fe71D00dE45F6077b022576C4B86B) |
2 participants
Description
Profile Page: Created a responsive, light/dark-mode compatible builder profile page in
packages/nextjs/app/builders/0x0ed3f043ad4fe71d00de45f6077b022576c4b86b/page.tsx, featuring:On-Chain Check-In: Displayed contract + transaction details with Arbiscan links.
Theme Support: Added Tailwind
dark:variants to support Scaffold-ETH-2’s theme toggle system.Profile Page — Light Mode
Profile Page — Dark Mode
Additional Information
Related Issues
Closes #10
ENS / Address:
0x0ed3f043ad4fe71d00de45f6077b022576c4b86b