fix: reward, bond and decider fee values #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swellander
approved these changes
Aug 18, 2025
Collaborator
swellander
left a comment
swellander
left a comment
There was a problem hiding this comment.
@AzimovS great catch and fix! Your changes all LGTM and seem to be working well. Thanks 🙏
escottalexander
approved these changes
Aug 19, 2025
Collaborator
escottalexander
left a comment
escottalexander
left a comment
There was a problem hiding this comment.
Nice work. Looks good. I will update the wording and code blocks in the README in my existing PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the constants. The reward can be any value, and the bond is twice the reward. The winner will receive the bond plus the reward, and the decider will receive the bond (for simplicity).
Please let me know if you have any suggestions.
Maybe we can merge this after Readme and I will make the changes for readme as well