Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-133: Vue and Nuxt Gen 2 - Custom components - Child blocks (all 3 examples) #3961

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

uttej-vsk
Copy link
Contributor

Description

This pull request (PR) adds Vue Gen 2 SDK code snippets for custom components docs.

@samijaber Please review this.

Copy link

changeset-bot bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: 9ad9595

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Mar 10, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11707119 Triggered Generic High Entropy Secret 56b9366 packages/sdks/snippets/vue/src/views/EditableRegions.vue View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Mar 10, 2025

View your CI Pipeline Execution ↗ for commit 9ad9595.

Command Status Duration Result
nx test @e2e/gen1-next15-app ❌ Failed 4m 49s View ↗
nx test @snippet/vue ❌ Failed 3m 25s View ↗
nx test @snippet/nuxt ❌ Failed 2m 43s View ↗
nx test @e2e/qwik-city ✅ Succeeded 7m 50s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 7m 36s View ↗
nx test @e2e/nuxt ✅ Succeeded 7m 8s View ↗
nx test @e2e/hydrogen ✅ Succeeded 6m 43s View ↗
nx test @e2e/angular-16-ssr ✅ Succeeded 6m 12s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-14 18:54:49 UTC

@samijaber
Copy link
Contributor

samijaber commented Mar 17, 2025

looks good to me, but snippets are falling for vue/nuxt so there may be a bug somewhere

@uttej-vsk
Copy link
Contributor Author

uttej-vsk commented Mar 17, 2025

looks good to me, but snippets are falling for vue/nuxt so there may be a bug somewhere

@samijaber Yeah, this is due to the playwright's timeout. So, I tried increasing the default timeout, and most of my branches are not having this issue. Let us try this assumption and see if it is solved. It won't impact other snippets, so it is safe to test it out. I have already added the fix in a few places.

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found the issue in this PR causing snippet test failure: I realized that you called the columns leftContent and rightContent, but in all other frameworks we call them column1 and column2.

the content entry expects the latter as the props name:

CleanShot 2025-03-17 at 16 01 26@2x

I think that's why the snippets are failing, and it is unrelated to extending the snippet timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants