-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-133: Vue and Nuxt Gen 2 - Custom components - Child blocks (all 3 examples) #3961
base: main
Are you sure you want to change the base?
Conversation
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11707119 | Triggered | Generic High Entropy Secret | 56b9366 | packages/sdks/snippets/vue/src/views/EditableRegions.vue | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
View your CI Pipeline Execution ↗ for commit 9ad9595.
☁️ Nx Cloud last updated this comment at |
looks good to me, but snippets are falling for vue/nuxt so there may be a bug somewhere |
@samijaber Yeah, this is due to the playwright's timeout. So, I tried increasing the default timeout, and most of my branches are not having this issue. Let us try this assumption and see if it is solved. It won't impact other snippets, so it is safe to test it out. I have already added the fix in a few places. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found the issue in this PR causing snippet test failure: I realized that you called the columns leftContent
and rightContent
, but in all other frameworks we call them column1
and column2
.
the content entry expects the latter as the props name:
I think that's why the snippets are failing, and it is unrelated to extending the snippet timeout
Description
This pull request (PR) adds Vue Gen 2 SDK code snippets for custom components docs.
@samijaber Please review this.