Custom Components - Child blocks - svelte & svelteKit all examples #3968
Conversation
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11707119 | Triggered | Generic High Entropy Secret | 6f1165a | packages/sdks/snippets/sveltekit/src/routes/editable-region/+page.svelte | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
View your CI Pipeline Execution ↗ for commit 2bcae8f.
☁️ Nx Cloud last updated this comment at |
| @@ -66,7 +66,7 @@ export default defineConfig({ | |||
| /** | |||
| * Increase the default timeout for snippet tests because they're not deterministic. | |||
| */ | |||
| timeout: testType === 'snippet' ? 30000 : 5000, | |||
| timeout: testType === 'snippet' ? 60000 : 5000, | |||
There was a problem hiding this comment.
curious question:
why do we have to ramp up the time for snippets?
There was a problem hiding this comment.
@yash-builder I tried debugging this issue and found this answer in Stackoverflow.
You currently don't specify a timeout when you call toBeVisible(), and your code defaults to 5000ms, which is 5 seconds.
Perhaps it is possible that the page locater is taking longer than 5 seconds to find the logout button.
One solution you can try; from https://playwright.dev/docs/test-timeouts:
await expect(logoutLink).toBeVisible({ timeout: 10000 });
To increase the timeout to a large enough value that it might be able to pick it up.
Await can take a really long time especially looking for elements so I think this would be a good first step.
So i came up with this assumption of increasing the timeout in our playwright.config.ts file like this:
expect: {
/**
* Increase the default timeout for snippet tests because they're not deterministic.
*/
timeout: testType === 'snippet' ? 60000 : 5000,
},
The comments even mentioned that we can increase the default timeout for snippet tests. But we didn't have this issue until the day before yesterday, so we had to change. This is just one assumption.
uttej-vsk
changed the title
Description
@samijaber This is part 2 of the Custom Components - Child Blocks ticket-133. It contains Svelte code for all three example snippets. Whenever you have the chance, please review this.
Update: I have pushed svelte and sveltekit to this PR.