fix: [ENG-8644] overriding omit in fetchOneEntry to be empty string #3975
Conversation
🦋 Changeset detectedLatest commit: 7465cfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 7465cfa.
☁️ Nx Cloud last updated this comment at |
|
@yash-builder could you add tests for this? this could be a reference |
| @@ -54,6 +54,18 @@ function App() { | |||
| } | |||
| }, []); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
I think the better way would be to add unit test in generate-content-url.test.ts instead of useEffect here. The aim is to respect empty string '' passed to omit field.
@samijaber or @sidmohanty11 can correct me on this.
There was a problem hiding this comment.
The snapshots also should be updated to differentiate omit as undefined vs omit as empty string.
ie generate-content-url.test.ts.snap
Description:
This PR fixes an issue where
meta.componentsUsedis omitted by default when usingfetchOneEntry. Previously, to includemeta.componentsUsed, you had to explicitly setomit: ' '(a space) as a workaround.Changes Made:
meta.componentsUsedby default unless explicitly omitted.omit ?? 'meta.componentsUsed'to ensurecomponentsUsedis not omitted whenomitis set to an empty string ('').Why This Change Was Made:
To allow
meta.componentsUsedto be included without requiring a workaround and to ensure better handling of theomitparameter.Loom
https://www.loom.com/share/938cd062796c4e2aaaf42b408039713e?sid=f087a66d-478d-42ce-ae41-b8e809535da6