Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
📝 WalkthroughWalkthroughThe PR updates the viem library dependency from ^2.44.2 to ^2.47.1 across the entire monorepo and introduces the ox library (^0.14.0) to apps/web. A new Attribution-based dataSuffix feature is added to Wagmi client configuration, conditionally driven by the NEXT_PUBLIC_BASE_BUILDER_CODE environment variable. Turbo configuration is updated to track .env files globally. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/web/src/utils/clientConfig.ts (1)
57-62: Consider adding validation for the builder code format.The current implementation trims whitespace but doesn't validate the format of
NEXT_PUBLIC_BASE_BUILDER_CODE. If the attribution spec expects a specific format (e.g., hex string, specific length), invalid values could produce malformed data suffixes.💡 Optional: Add format validation
const baseBuilderCode = process.env.NEXT_PUBLIC_BASE_BUILDER_CODE?.trim() + +// Validate builder code format if required by ERC-8021 +const isValidBuilderCode = (code: string | undefined): code is string => { + return !!code && code.length > 0 // Add specific format validation as needed +} + -const dataSuffix = baseBuilderCode +const dataSuffix = isValidBuilderCode(baseBuilderCode) ? Attribution.toDataSuffix({ codes: [baseBuilderCode], }) : undefined🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/web/src/utils/clientConfig.ts` around lines 57 - 62, Validate NEXT_PUBLIC_BASE_BUILDER_CODE after trimming (baseBuilderCode) before passing it to Attribution.toDataSuffix: check it matches the expected format (e.g., regex for hex or required length) and only call Attribution.toDataSuffix when the value is valid; if invalid, handle gracefully by leaving dataSuffix undefined and optionally logging or throwing a clear error. Update the code around baseBuilderCode/dataSuffix to perform the format check and include the validation logic and error-handling path.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/web/src/utils/clientConfig.ts`:
- Around line 57-62: Validate NEXT_PUBLIC_BASE_BUILDER_CODE after trimming
(baseBuilderCode) before passing it to Attribution.toDataSuffix: check it
matches the expected format (e.g., regex for hex or required length) and only
call Attribution.toDataSuffix when the value is valid; if invalid, handle
gracefully by leaving dataSuffix undefined and optionally logging or throwing a
clear error. Update the code around baseBuilderCode/dataSuffix to perform the
format check and include the validation logic and error-handling path.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c5fdd959-b652-447e-a766-c2285ade2c65
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (18)
apps/web/package.jsonapps/web/src/utils/clientConfig.tspackage.jsonpackages/auction-ui/package.jsonpackages/blocklist/package.jsonpackages/create-dao-ui/package.jsonpackages/create-proposal-ui/package.jsonpackages/dao-ui/package.jsonpackages/feed-ui/package.jsonpackages/hooks/package.jsonpackages/proposal-ui/package.jsonpackages/sdk/package.jsonpackages/swap/package.jsonpackages/test-fixtures/package.jsonpackages/types/package.jsonpackages/ui/package.jsonpackages/utils/package.jsonturbo.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Updates