Skip to content

Avoid alignment-sensitive cast in read_f64_into on AIX #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amy-kwan wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −5
Open

Avoid alignment-sensitive cast in read_f64_into on AIX #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa8b00
Fix read_f64_into() for AIX.
amy-kwan Apr 15, 2026
073bdbc
Fix formatting issues.
amy-kwan May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,11 +1219,26 @@ pub trait ByteOrder:
/// ```
#[inline]
fn read_f64_into(src: &[u8], dst: &mut [f64]) {
let dst = unsafe {
const _: () = assert!(align_of::<u64>() <= align_of::<f64>());
slice::from_raw_parts_mut(dst.as_mut_ptr() as *mut u64, dst.len())
};
Self::read_u64_into(src, dst);
#[cfg(not(target_os = "aix"))]
{
let dst = unsafe {
const _: () = assert!(align_of::<u64>() <= align_of::<f64>());
slice::from_raw_parts_mut(
dst.as_mut_ptr() as *mut u64,
dst.len(),
)
};
Self::read_u64_into(src, dst);
}
#[cfg(target_os = "aix")]
{
// On AIX, `f64` may be less aligned than `u64`, so we cannot safely
// reinterpret `dst` as `&mut [u64]`.
const _: () = assert!(align_of::<f64>() <= align_of::<u64>());
for (s, d) in src.chunks_exact(8).zip(dst.iter_mut()) {
*d = Self::read_f64(s);
}
}
}

/// **DEPRECATED**.
Expand Down
Loading