Repository navigation
feat: integrate PSFramework for structured logging and configuration - #5
Open
BurtHarris with Copilot wants to merge 3 commits into
Open
BurtHarris with Copilot wants to merge 3 commits into
BurtHarris with Copilot wants to merge 3 commits into
Conversation
…onfiguration - Add PSFramework >= 1.0.0 as RequiredModule in the manifest - Replace Write-Output placeholder with Write-PSFMessage (Verbose) - Add Stop-PSFFunction for error handling inside Get-PasskeyDiagnosticInfo - Register PasskeyDiagnostics.LogLevel config via Set-PSFConfig -Initialize - Add comment-based help to Get-PasskeyDiagnosticInfo - Install PSFramework in CI workflow before running Pester tests - Expand Pester tests: cover return-value properties and PSFramework config - Update README: add PSFramework prerequisite and usage note Closes #4
Copilot
AI
changed the title
[WIP] Integrate PSFramework into existing code
feat: integrate PSFramework for structured logging and configuration
Jul 7, 2026
BurtHarris
approved these changes
Jul 7, 2026
BurtHarris
marked this pull request as ready for review
July 7, 2026 20:41
Owner
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # PasskeyDiagnostics/PasskeyDiagnostics.psm1 # README.md # tests/PasskeyDiagnostics.Tests.ps1
Contributor
Author
Merge conflicts resolved in commit What conflicted: PR #3 (merged to How it was resolved:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires in PSFramework as a first-class dependency, replacing ad-hoc
Write-Outputwith structured, leveled messaging and adding a persistent config entry.Module (
PasskeyDiagnostics.psm1/.psd1)RequiredModulesnow enforcesPSFramework >= 1.0.0Write-Outputreplaced withWrite-PSFMessage -Level Verbose— messages route to both the Verbose stream and the PSFramework in-memory/file log automaticallyStop-PSFFunctionused for error handling (non-terminating, PSF-aware)Set-PSFConfig -Initializeregisters aPasskeyDiagnostics.LogLevelentry users can override via the PSFramework config systemCI (
.github/workflows/test.yml)Install PSFrameworkstep mirroring the existing Pester install patternTests (
PasskeyDiagnostics.Tests.ps1)#Requires -Modules PSFrameworkGet-PasskeyDiagnosticInforeturn-value shape and the registered PSFramework config entry/default value