Skip to content

Conversation

@ggamnunq
Copy link
Contributor

@ggamnunq ggamnunq commented Aug 18, 2025

  • 장소&축제 정보 추가 api 구현
  • 테이블 컬럼 속성 일부 변경

Summary by CodeRabbit

  • 신규 기능

    • 외부 관광 API 연동으로 축제/장소 데이터 수집 및 저장 기능 추가
    • 축제·장소 동기화용 관리용 엔드포인트 제공
  • 변경 사항

    • 홈/검색/지도 응답의 위도·경도 값을 선택적(Null 허용)으로 변경하여 좌표 미제공 데이터도 표시 가능
    • 축제 요금 정보를 문자열로 표기하도록 변경
    • 장소 정보에 운영시간·휴무일 필드가 반영되어 응답에 포함
    • 축제 상태에 UNKNOWN 추가
  • 작업/환경

    • 웹 클라이언트 및 XML 파싱 의존성 추가
    • JDBC 디버그 로깅 활성화 및 외부 API 키 설정 항목 추가

@ggamnunq ggamnunq self-assigned this Aug 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2025

Walkthrough

Gradle adds XML and WebFlux dependencies. Domain models and DTOs adjust types (fees, coordinates) and associations. New enums/constants are introduced. A Tour API ingestion feature is added with controller, service, utilities, DTOs, and JDBC batch repo. Application logging config changes and a tourAPI key is added.

Changes

Cohort / File(s) Summary
Build Config
build.gradle
Adds jackson-dataformat-xml:2.17.0 and spring-boot-starter-webflux dependencies.
Festival Domain
.../festival/domain/Festival.kt, .../festival/domain/FestivalImage.kt, .../festival/enums/FestivalStatus.kt
Festival: add unique non-null contentId, fee Int→String, images Set→MutableSet with cascade ALL, orphanRemoval, helper addFestivalImage; FestivalImage: festival val→var; FestivalStatus: add UNKNOWN.
Home DTO/Service
.../home/dto/HomeResponseDTO.kt, .../home/service/HomeQueryService.kt
Latitude/longitude become nullable in DTOs; service mapping uses safe calls to propagate nulls.
Place Domain & Repo
.../place/domain/Place.kt, .../place/repository/PlaceJdbcRepository.kt, .../place/enums/PlaceType.kt, .../place/dto/PlaceMapResponseDTO.kt
Place: add unique contentId, latitude/longitude nullable, openTime nullable, add useTime/restDate, images MutableSet with cascade/orphanRemoval, add addImage/removeImage; JDBC batch repository added for inserts; PlaceType gains tourApiTypeId/useTime/restDate columns and CULTURE + mapper; DTOs latitude/longitude nullable.
Region Entity Toggle
.../place/domain/Region.kt
@entity commented out (class no longer a JPA entity).
Search Service
.../search/service/SearchQueryService.kt
Coordinate mapping changed to nullable safe conversions.
Tour API Controller/Service
.../tourApi/controller/TourAPIController.kt, .../tourApi/service/TourCommandService.kt
Controller exposes POST /tour-api/festivals and /tour-api/place; Service syncs festivals and ingests places from external APIs, maps to entities, persists.
Tour API Utilities & DTOs
.../tourApi/util/TourFestivalUtil.kt, .../tourApi/util/TourPlaceUtil.kt, .../tourApi/util/TourFestivalConverter.kt, .../tourApi/dto/* (Festival, PlaceCommon, PlaceIntro, PlaceRegion), .../tourApi/enums/TourPlaceType.kt
Adds WebClient/HTTP utilities for external API calls, Jackson DTOs for responses, converter for Festival mapping and status/date parsing, and TourPlaceType enum.
Application Config
src/main/resources/application.yml
Switches logging to JDBC DEBUG categories; adds tourAPI.key property sourced from env.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant TourAPIController
  participant TourCommandService
  participant TourFestivalUtil
  participant FestivalRepository

  Client->>TourAPIController: POST /tour-api/festivals
  TourAPIController->>TourCommandService: syncFestivalsFromApi()
  TourCommandService->>TourFestivalUtil: getFestivals()
  TourFestivalUtil-->>TourCommandService: List<FestivalItem>
  TourCommandService->>TourCommandService: map items to Festival entities
  TourCommandService->>FestivalRepository: saveAll(festivals)
  FestivalRepository-->>TourCommandService: persisted
  TourCommandService-->>TourAPIController: done
  TourAPIController-->>Client: 200
Loading
sequenceDiagram
  participant Client
  participant TourAPIController
  participant TourCommandService
  participant TourPlaceUtil
  participant PlaceRepository

  Client->>TourAPIController: POST /tour-api/place?place-type=...
  TourAPIController->>TourCommandService: getPlace(placeType)
  TourCommandService->>TourPlaceUtil: getPlace(placeType)
  TourPlaceUtil-->>TourCommandService: PlaceApiResponseWrapper
  loop for each item
    TourCommandService->>TourPlaceUtil: getPlaceDetail(contentId)
    TourPlaceUtil-->>TourCommandService: PlaceCommonApiWrapper
    TourCommandService->>TourPlaceUtil: getPlaceIntro(contentId, typeId)
    TourPlaceUtil-->>TourCommandService: PlaceIntroductionResponseWrapper
    TourCommandService->>TourCommandService: build Place entity (+images)
  end
  TourCommandService->>PlaceRepository: saveAll(places)
  PlaceRepository-->>TourCommandService: persisted
  TourCommandService-->>TourAPIController: done
  TourAPIController-->>Client: 200
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

바다 바람 흔드는 버스안바이브 깃발, 🐇
새 좌표는 null도 품고 살살—
축제는 UNKNOWN도 포함해 보자,
관광 API로 담근 한 솥 국, 웹플럭스 팔짝!
이미지 척, JDBC 척,
깡총깡총 릴리즈로 가을빛을 적어 넣는다. 🌊🎉

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d9c1656 and a751fe7.

⛔ Files ignored due to path filters (1)
  • .DS_Store is excluded by !**/.DS_Store
📒 Files selected for processing (24)
  • build.gradle (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/domain/Festival.kt (4 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/domain/FestivalImage.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/dto/FestivalDetailsDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/enums/FestivalStatus.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/home/dto/HomeResponseDTO.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/home/service/HomeQueryService.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/domain/Place.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/domain/Region.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/dto/PlaceMapResponseDTO.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/enums/PlaceType.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/repository/PlaceJdbcRepository.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/search/service/SearchQueryService.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/controller/TourAPIController.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/dto/TourFestivalDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/dto/TourPlaceCommonDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/dto/TourPlaceIntroDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/dto/TourPlaceRegionDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/enums/TourPlaceType.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/service/TourCommandService.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/util/TourFestivalConverter.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/util/TourFestivalUtil.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/util/TourPlaceUtil.kt (1 hunks)
  • src/main/resources/application.yml (2 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ggamnunq ggamnunq merged commit c42cdb6 into main Aug 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants