Skip to content

Conversation

@ggamnunq
Copy link
Contributor

@ggamnunq ggamnunq commented Aug 18, 2025

  • 응답값 통일
    • 명소 & 축제 응답값 통일 place_id, festival_id -> id
    • 명소 useTime, restDate 추가
    • 명소 타입별 응답형태 통일
    • 명소 축제 좋아요 수 응답값 통일 -> like_amount
  • 게스트 로그인 구현
    • 게스트 로그인 구현
    • api uri 수정 -> 유저 관련 api는 "/api" 제거
    • http 메서드 get -> post 수정
    • http 메서드 수정
  • 디스코드 웹훅 설정 변경 ( 들여쓰기 문제 수정 )

Summary by CodeRabbit

  • 신기능
    • 게스트 로그인 엔드포인트 추가 (/users/guest/login)
  • 변경사항
    • API 기본 경로 정리: /chat → /api/chat, /tour-api → /api/tour
    • 응답 필드 명 통일: placeId/festivalId → id, likeCount → likeAmount
    • 장소 목록/지도 응답의 식별자 필드 id로 변경
    • 장소 상세 응답 구조 통일 및 필드 추가: useTime, restDate
  • 버그 수정
    • 액세스 토큰 만료시간 설정 오류 수정
  • 문서
    • Swagger 태그/설명 보강 및 상세 설명 추가
  • 업무
    • Discord 알림 포맷 개선 (가독성 향상)

@ggamnunq ggamnunq self-assigned this Aug 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

여러 DTO의 필드 이름을 placeId/festivalId/likeCount 등에서 id/likeAmount로 변경하고, 해당 매핑·정렬 코드를 업데이트했습니다. 장소 상세는 Sight 전용으로 단일화하고 Sight DTO에 useTime/restDate를 추가했습니다. 사용자에 게스트 로그인 엔드포인트를 추가하고 시큐리티 허용 경로를 확장했으며, 일부 컨트롤러의 베이스 경로를 /api/** 로 변경했습니다. GitHub Actions는 메시지 조립/페이로드 포맷만 조정되었습니다.

Changes

Cohort / File(s) Summary
CI Discord 메시지 포맷
.github/workflows/discord.yml
jq 문자열 결합 방식으로 단순화, 페이로드에 실제 개행 사용. 기능 동일.
라우팅 베이스 경로 변경
.../chat/controller/ChatRestController.kt, .../tourApi/controller/TourAPIController.kt
베이스 경로를 각각 /api/chat, /api/tour 로 변경. TourAPIController에 @tag 추가.
Festival DTO/서비스 정합화
.../festival/dto/FestivalListResponseDTO.kt, .../festival/dto/FestivalDetailsDTO.kt, .../festival/converter/FestivalConverter.kt, .../festival/service/FestivalQueryService.kt
festivalId→id, likeCount→likeAmount로 필드명 변경 및 매핑/정렬 수정.
Home DTO/서비스 정합화
.../home/dto/HomeResponseDTO.kt, .../home/service/HomeQueryService.kt
placeId→id로 필드명 변경 및 생성자 인자명 수정.
Place DTO/컨버터/서비스 변경
.../place/dto/PlaceResponseDTO.kt, .../place/converter/PlaceDetailsConverter.kt, .../place/service/PlaceQueryService.kt
PlaceListInfoDto의 placeId→id. SightDto에 useTime/restDate 추가. Restaurant/Review DTO 및 변환 로직 비활성화(주석) 및 상세 응답을 Sight 단일 경로로 단순화.
Place 지도 DTO/서비스 정합화
.../place/dto/PlaceMapResponseDTO.kt, .../place/service/PlaceCongestionQueryService.kt
PlaceMapInfoDto의 placeId→id 및 호출부 인자명 반영.
Place 컨트롤러 문서
.../place/controller/PlaceController.kt
@operation에 상세 설명 추가(응답 형태/타입 값 안내).
유저: 게스트 로그인 추가 및 시큐리티
.../user/controller/UserController.kt, .../user/service/UserCommandService.kt, .../global/config/security/SecurityConfig.kt
POST /users/guest/login 추가(토큰 응답 반환), test 엔드포인트 제거. 서비스에 guestLogin 추가 및 isNewUser 시그니처 단순화. 시큐리티에서 공개 경로로 허용.
JWT 액세스 만료시간 수정
.../global/config/security/JwtTokenProvider.kt
액세스 토큰 만료를 ACCESS_TOKEN_EXPIRE_TIME 사용으로 수정.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant API as UserController
  participant Service as UserCommandService
  participant Auth as JwtTokenProvider
  Client->>API: POST /users/guest/login
  API->>Service: guestLogin()
  Service->>Service: 게스트 이메일/닉네임 생성(UUID)
  Service->>Service: isNewUser(email, nickname, profileImageUrl)
  Service->>Auth: 토큰 생성 요청
  Auth-->>Service: TokenResponseDto
  Service-->>API: LoginDto(tokenResponseDTO)
  API-->>Client: ApiResponse<TokenResponseDto>
Loading
sequenceDiagram
  participant Client
  participant API as PlaceController
  participant Svc as PlaceQueryService
  participant Conv as PlaceDetailsConverter
  Client->>API: GET /places/{placeId}
  API->>Svc: getPlaceDetails(placeId)
  Svc->>Conv: toSightDto(...)
  Conv-->>Svc: SightDto(useTime, restDate 포함)
  Svc-->>API: PlaceDetailsDto.SightDto
  API-->>Client: 200 OK
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

밤바람 슥- API 길 바꿔 탄 토끼 한 마리
placeId는 짧게 id로, like는 더 크게 셌지(∩^o^)⊃━☆
식당 길 접고 Sight로 직진!
게스트 문 활짝, 토큰은 뿅!
디스코드엔 줄바꿈 춤, 코드엔 질서가 둠칫둠칫 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c42cdb6 and 1b32e57.

📒 Files selected for processing (19)
  • .github/workflows/discord.yml (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/chat/controller/ChatRestController.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/converter/FestivalConverter.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/dto/FestivalDetailsDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/dto/FestivalListResponseDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/service/FestivalQueryService.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/home/dto/HomeResponseDTO.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/home/service/HomeQueryService.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/controller/PlaceController.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/converter/PlaceDetailsConverter.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/dto/PlaceMapResponseDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/dto/PlaceResponseDTO.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/service/PlaceCongestionQueryService.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/service/PlaceQueryService.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/controller/TourAPIController.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/user/controller/UserController.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/user/service/UserCommandService.kt (3 hunks)
  • src/main/kotlin/busanVibe/busan/global/config/security/JwtTokenProvider.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/global/config/security/SecurityConfig.kt (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ggamnunq ggamnunq merged commit 5a79351 into main Aug 18, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants