-
Notifications
You must be signed in to change notification settings - Fork 1
지역축제 목록 조회 API 수정 #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- 반환 타입 문제 해결 - 응답 npe 발생 해결
|
Caution Review failedThe pull request is closed. Walkthrough페스티벌 목록 API의 반환 타입을 non-null로 변경하고 Swagger 주석을 제거. 좋아요 조회는 Repository 쿼리를 LEFT JOIN FETCH로 수정하고 Service에서 해당 메서드를 사용하도록 변경. Home/Search/User Likes 관련 DTO의 필드명과 JSON 키를 isLiked→isLike로 일괄 변경하며 관련 사용처를 업데이트. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Controller as FestivalController
participant Service as FestivalQueryService
participant RepoF as FestivalRepository
participant RepoL as FestivalLikesRepository
participant Storage as DB
Client->>Controller: GET /festivals?sort=&status=
Controller->>Service: festivalList(sort, status)
Service->>RepoF: findBy(sort, status)
RepoF->>Storage: Query festivals
Storage-->>RepoF: List<Festival>
RepoF-->>Service: festivals
Service->>RepoL: findLikeByFestival(festivals)
Note right of RepoL: LEFT JOIN FETCH fl.user
RepoL->>Storage: Query likes + user
Storage-->>RepoL: List<FestivalLike> (+User)
RepoL-->>Service: likes
Service-->>Controller: ApiResponse<ListDto>
Controller-->>Client: 200 OK (non-null ApiResponse)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (8)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
새 기능
리팩터
버그 수정
작업(Chores)