검색 & 명소 & 채팅 수정 #52
Merged
검색 & 명소 & 채팅 수정 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. Walkthrough채팅 엔드포인트에 Bean Validation과 OpenAPI 메타데이터가 추가되고, 길이 검증 로직이 서비스에서 제거되었습니다. 검색 API는 keyword 파라미터를 도입해 서버 측 필터링을 수행합니다. CAFE 관련 enum/분기들이 비활성화되었습니다. 전역 예외 처리에 HttpMessageNotReadable 처리기가 추가되었습니다. 일부 컨트롤러에 Swagger 메타데이터가 보강되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant R as ChatRestController
participant V as Bean Validation
participant S as ChatMongoService
participant M as ChatMongoRepository
participant P as RedisPublisher
C->>R: POST /api/chat/send (ChatMessageSendDTO)
R->>V: DTO 검증(@NotBlank, @Size)
alt 유효성 위반
V-->>R: ConstraintViolationException
R-->>C: 400 Bad Request (전역 핸들러)
else 유효
R->>S: sendMessage(chatMessage)
S->>M: save(ChatMessage)
M-->>S: saved document
S->>P: publish(ChatMessageReceiveDTO)
P-->>C: (구독자에게 전파)
S-->>R: 완료
R-->>C: 200 OK
end
note over R,S: 이전의 길이 에러 WebSocket 전송 경로 제거됨
sequenceDiagram
autonumber
participant C as Client
participant SC as SearchController
participant SQ as SearchQueryService
C->>SC: GET /api/search?option=...&sort=...&keyword=...
SC->>SQ: getSearchResult(infoType, sort, keyword)
alt infoType == CAFE
note over SQ: CAFE 분기 비활성화
SQ-->>SC: 빈 결과 리스트 포함 DTO
else 다른 타입
SQ->>SQ: 목록 생성 → keyword 필터(공백 제거, 대소문자 무시)
SQ-->>SC: 필터링된 리스트 포함 DTO
end
SC-->>C: 200 OK (SearchResultDTO)
sequenceDiagram
autonumber
participant C as Client
participant S as Server
participant EA as ExceptionAdvice
C->>S: 요청 본문 파싱 불가(JSON 오류 등)
S-->>EA: HttpMessageNotReadableException
EA-->>C: 400 Bad Request (매핑된 한글 메시지)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (12)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleHttpMessageNotReadable())Summary by CodeRabbit