Skip to content

[Fix/#84] 용어 상세 페이지 관련용어 탭 수정 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyesngy merged 2 commits into from
Nov 30, 2025
Merged

[Fix/#84] 용어 상세 페이지 관련용어 탭 수정 #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e327f5
fix(termsDetail): 관련용어 탭 리팩토링
hyesngy Nov 30, 2025
98fc940
fix: 빌드 에러 해결
hyesngy Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/term-detail/TabSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function TabSection({ term, relatedTerms }: TabSectionProps) {
{activeTab === "description" && <DescriptionTab term={term} />}
{activeTab === "usecase" && <UseCaseTab term={term} />}
{activeTab === "related" && (
<RelatedTab term={term} relatedTerms={relatedTerms} />
<RelatedTab relatedTerms={relatedTerms} />
)}
</div>
</section>
Expand Down
43 changes: 2 additions & 41 deletions src/components/term-detail/tabs/RelatedTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
"use client";

import { useState, useEffect } from "react";
import { useRouter } from "next/navigation";
import { cn } from "@/utils/cn";
import type { TermDetail, TermIndexItem } from "@/lib/terms";
import { getRelatedTerms } from "@/lib/terms";
import type { TermIndexItem } from "@/lib/terms";
import {
RelationIcon,
HashtagIcon,
Expand All @@ -16,11 +14,10 @@ import { getCategoryType } from "@/lib/category";
import { useScrapToggle } from "@/hooks/useScrapToggle";

interface RelatedTabProps {
term: TermDetail;
relatedTerms: TermIndexItem[];
}

export function RelatedTab({ term, relatedTerms }: RelatedTabProps) {
export function RelatedTab({ relatedTerms }: RelatedTabProps) {
return (
<article className="flex flex-col gap-5 rounded-xl border border-gray-800 p-7">
<div className="flex items-center gap-2">
Expand All @@ -37,11 +34,6 @@ export function RelatedTab({ term, relatedTerms }: RelatedTabProps) {
) : (
<p className="text-body5 text-gray-500">연관 용어가 없습니다.</p>
)}

{/* Confusable Terms */}
{term.confusableIds && term.confusableIds.length > 0 && (
<ConfusableTerms ids={term.confusableIds} />
)}
</article>
);
}
Expand Down Expand Up @@ -144,34 +136,3 @@ function RelatedTermCard({ term }: { term: TermIndexItem }) {
</div>
);
}

// Confusable Terms
function ConfusableTerms({ ids }: { ids: number[] }) {
const router = useRouter();
const [terms, setTerms] = useState<TermIndexItem[]>([]);

useEffect(() => {
getRelatedTerms(ids).then(setTerms);
}, [ids]);

if (terms.length === 0) return null;

return (
<div className="mt-4 border-t border-gray-800 pt-4">
<p className="text-caption1 mb-2 text-gray-500">헷갈리기 쉬운 용어</p>
<ul className="flex flex-col gap-2">
{terms.map((t) => (
<li key={t.id}>
<button
onClick={() => router.push(`/terms/${t.slug}`)}
className="hover:bg-white-5 flex w-full items-center gap-2 rounded-lg p-2 text-left transition-colors"
>
<span className="text-body5 text-white">{t.termKo}</span>
<span className="text-caption1 text-gray-600">vs</span>
</button>
</li>
))}
</ul>
</div>
);
}