write tests after the fact, add travis config#10
write tests after the fact, add travis config#10andreas-bytenl wants to merge 6 commits intomasterfrom
Conversation
|
Having a hard time nailing down dependencies that work with Python 2.6 :( |
andreas-bytenl
force-pushed
the
fix-tests
branch
from
1e745f6 to
a193c9e
Compare
kerrermanisNL
left a comment
kerrermanisNL
left a comment
There was a problem hiding this comment.
Looks okay, just a few questions.
| .pydevproject | ||
| .idea | ||
| .pytest_cache | ||
| /htmlcov |
There was a problem hiding this comment.
Where does this come from? We don't have any HTML in here that needs to be covered, right? :P
There was a problem hiding this comment.
If you run pytest --cov (with some extra arguments), you'll get a directory htmlcov which shows you which parts of your code hasn't been ran by tests. I should add this to the readme.
| @@ -0,0 +1,4 @@ | |||
| pytest | |||
| pytest-cov | |||
There was a problem hiding this comment.
Why pytest specifically? All other repo's use nosetests I think. I think we should stick with the same requirements in general.
| @@ -0,0 +1,4 @@ | |||
| pytest | |||
| pytest-cov | |||
| prospector | |||
There was a problem hiding this comment.
A tool that combines pylint, pyflakes and pycodestyle. Used by https://landscape.io/
|
Cool. What about the pytest question? |
|
@kerrermanisNL I forgot about this PR. We discussed this internally, I think I tried rewriting to regular unittest but got too annoyed by it and did other things instead :p |
2 participants
No description provided.